Remove "Back to home" link on import errors when not loading from file (#5279)

Co-authored-by: Nazım Can Altınova <[email protected]>

Author: nisargjhaveri

src/components/app/AppViewRouter.tsx

@@ -98,6 +98,8 @@ class AppViewRouterImpl extends PureComponent<AppViewRouterProps> {
           }
         }
 
+        const showBackHomeLink = dataSource === 'from-file';
+
         return (
           <Localized
             id={message}
@@ -116,7 +118,7 @@ class AppViewRouterImpl extends PureComponent<AppViewRouterProps> {
             <ProfileRootMessage
               additionalMessage={additionalMessage}
               showLoader={false}
-              showBackHomeLink={true}
+              showBackHomeLink={showBackHomeLink}
             >{`missing translation for ${message}`}</ProfileRootMessage>
           </Localized>
         );

src/components/app/ProfileLoaderAnimation.tsx

@@ -61,7 +61,8 @@ class ProfileLoaderAnimationImpl extends PureComponent<ProfileLoaderAnimationPro
     const showBackHomeLink = Boolean(
       'additionalData' in view &&
         view.additionalData &&
-        view.additionalData.message
+        view.additionalData.message &&
+        dataSource === 'from-file'
     );
 
     return (

src/test/components/Root.test.tsx

@@ -135,11 +135,11 @@ describe('app/AppViewRouter', function () {
     const {
       container,
       dispatch,
-      navigateToStoreLoadingPage,
+      navigateToFromFileProfileLoadingPage,
       navigateBackToHome,
     } = setup();
 
-    navigateToStoreLoadingPage();
+    navigateToFromFileProfileLoadingPage();
     dispatch(fatalError(new Error('Error while loading profile')));
     expect(container.firstChild).toMatchSnapshot();
     expect(console.error).toHaveBeenCalled();
@@ -148,6 +148,15 @@ describe('app/AppViewRouter', function () {
     expect(container.firstChild).toMatchSnapshot();
   });
 
+  it('does not render back home link when not opened with from-file', function () {
+    const { container, dispatch, navigateToStoreLoadingPage } = setup();
+
+    navigateToStoreLoadingPage();
+    dispatch(fatalError(new Error('Error while loading profile')));
+    expect(container.firstChild).toMatchSnapshot();
+    expect(console.error).toHaveBeenCalled();
+  });
+
   it('renders a compare home when navigating to /compare/, then loads when changing profiles', () => {
     const { container, dispatch, navigateToCompareHome } = setup();
 
@@ -211,6 +220,15 @@ function setup() {
     actAndDispatch(updateUrlState(newUrlState));
   }
 
+  function navigateToFromFileProfileLoadingPage() {
+    const newUrlState = stateFromLocation({
+      pathname: '/from-file/calltree',
+      search: '',
+      hash: '',
+    });
+    actAndDispatch(updateUrlState(newUrlState));
+  }
+
   function navigateBackToHome() {
     const newUrlState = stateFromLocation({
       pathname: '/',
@@ -243,6 +261,7 @@ function setup() {
     dispatch: actAndDispatch,
     navigateToStoreLoadingPage,
     navigateToFromBrowserProfileLoadingPage,
+    navigateToFromFileProfileLoadingPage,
     navigateBackToHome,
     navigateToCompareHome,
     navigateToMyProfiles,

src/test/components/__snapshots__/Root.test.tsx.snap

@@ -1,5 +1,38 @@
 // Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
+exports[`app/AppViewRouter does not render back home link when not opened with from-file 1`] = `
+<div
+  class="rootMessageContainer"
+>
+  <div
+    class="rootMessage"
+  >
+    <h1
+      class="rootMessageTitle"
+    >
+      Firefox Profiler
+    </h1>
+    <div
+      class="rootMessageText"
+    >
+      <p>
+        Could not download the profile.
+      </p>
+    </div>
+    <div
+      class="rootMessageAdditional"
+    >
+      <p>
+        Error: Error while loading profile
+      </p>
+      <p>
+        The full stack has been written to the Web Console.
+      </p>
+    </div>
+  </div>
+</div>
+`;
+
 exports[`app/AppViewRouter does not try to retrieve a profile when moving from from-browser to public 1`] = `<profile-viewer />`;
 
 exports[`app/AppViewRouter renders an home when the user pressed back after an error 1`] = `
@@ -18,7 +51,7 @@ exports[`app/AppViewRouter renders an home when the user pressed back after an e
       class="rootMessageText"
     >
       <p>
-        Could not download the profile.
+        Couldn’t read the file or parse the profile in it.
       </p>
     </div>
     <div
@@ -77,15 +110,6 @@ exports[`app/AppViewRouter renders temporary errors 1`] = `
         Tried 3 times out of 10.
       </p>
     </div>
-    <div
-      class="rootBackHomeLink"
-    >
-      <a
-        href="/"
-      >
-        Back to home
-      </a>
-    </div>
     <div
       class="loading"
     >