Support symbolicating .json.gz files.

Author: mstange

package.json

@@ -122,6 +122,7 @@
     "@types/common-tags": "^1.8.4",
     "@types/jest": "^30.0.0",
     "@types/minimist": "^1.2.5",
+    "@types/node": "^22.17.2",
     "@types/query-string": "^6.3.0",
     "@types/react": "^18.3.24",
     "@types/react-dom": "^18.3.1",

src/profile-logic/process-profile.ts

@@ -2001,7 +2001,7 @@ export async function unserializeProfileOfArbitraryFormat(
         arbitraryFormat = convertSimpleperfTraceProfile(arrayBuffer);
       } else {
         try {
-          const textDecoder = new TextDecoder();
+          const textDecoder = new TextDecoder(undefined, { fatal: true });
           arbitraryFormat = await textDecoder.decode(arrayBuffer);
         } catch (e) {
           console.error('Source exception:', e);

src/symbolicator-cli/index.ts

@@ -79,8 +79,21 @@ export interface CliOptions {
 
 export async function run(options: CliOptions) {
   console.log(`Loading profile from ${options.input}`);
-  const serializedProfile = JSON.parse(fs.readFileSync(options.input, 'utf8'));
-  const profile = await unserializeProfileOfArbitraryFormat(serializedProfile);
+
+  // Read the raw bytes from the file. It might be a JSON file, but it could also
+  // be a binary file, e.g. a .json.gz file, or any of the binary formats supported
+  // by our importers.
+  const bytes = fs.readFileSync(options.input, null);
+
+  // bytes is a Uint8Array whose underlying ArrayBuffer can be longer than bytes.length.
+  // Copy the contents into a new ArrayBuffer which is sized correctly, so that we
+  // don't include uninitialized data from the extra parts of the underlying buffer.
+  // Alternatively, we could make unserializeProfileOfArbitraryFormat support
+  // Uint8Array or Buffer in addition to ArrayBuffer.
+  const byteBufferCopy = Uint8Array.prototype.slice.call(bytes).buffer;
+
+  // Load the profile.
+  const profile = await unserializeProfileOfArbitraryFormat(byteBufferCopy);
   if (profile === undefined) {
     throw new Error('Unable to parse the profile.');
   }

src/test/fixtures/node-worker.ts

@@ -2,7 +2,10 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-import { Worker as NodeWorkerClass } from 'worker_threads';
+import {
+  Worker as NodeWorkerClass,
+  isMarkedAsUntransferable,
+} from 'worker_threads';
 
 function getWorkerScript(file: string): string {
   return `
@@ -52,7 +55,11 @@ export class NodeWorker {
     if (+major < 11 || (+major === 11 && +minor < 12)) {
       payload = { data: message };
     }
-    this._instance?.postMessage(payload, transfer);
+    // See https://github.com/nodejs/node/issues/55593
+    const actualTransfer = (transfer ?? []).filter(
+      (buf) => !isMarkedAsUntransferable(buf)
+    );
+    this._instance?.postMessage(payload, actualTransfer);
   }
 
   onMessage = (message: unknown) => {