Skip to content

Commit 50e6530

Browse files
committed
Fix prettier issues
1 parent 899966e commit 50e6530

File tree

5 files changed

+37
-28
lines changed

5 files changed

+37
-28
lines changed

docs-developer/call-tree.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ One key point of the aggregation done in the call tree is that it's focused on w
6767

6868
Imagine this simplified example of 3 samples of mixed C++, JavaScript Code (js), and JIT optimized JavaScript (JIT). The functions are all labeled as to their implementation.
6969

70-
| Sample index | Sample's stack |
71-
| ------------ | ---------------------------------------------------------------------------------------------- |
72-
| 0 | `JS::RunScript [c++] ➡ onLoad [js] ➡ a [js] ➡ b [js]` |
70+
| Sample index | Sample's stack |
71+
| ------------ | ------------------------------------------------------------------------------------------ |
72+
| 0 | `JS::RunScript [c++] ➡ onLoad [js] ➡ a [js] ➡ b [js]` |
7373
| 1 | `JS::RunScript [c++] ➡ onLoad [js] ➡ js::jit::IonCannon [c++] ➡ a [JIT] ➡ b [JIT]` |
7474
| 2 | `JS::RunScript [c++] ➡ onLoad [js] ➡ js::jit::IonCannon [c++] ➡ a [JIT] ➡ b [JIT]` |
7575

@@ -113,8 +113,8 @@ Now, taking the stacks and building a call tree produces the following:
113113

114114
This is the correct tree of what you would want to see. But since we are mixing languages together into the same stack system, it might be nice to view only JS functions. In order to do that we hide any C++ stacks, and assign them to the nearest JS stack. Our tables would be updated to look like the following.
115115

116-
| Sample index | Sample's stack |
117-
| ------------ | --------------------------------------- |
116+
| Sample index | Sample's stack |
117+
| ------------ | ------------------------------------- |
118118
| 0 | `onLoad [js] ➡ a [js] ➡ b [js]` |
119119
| 1 | `onLoad [js] ➡ a [JIT] ➡ b [JIT]` |
120120
| 2 | `onLoad [js] ➡ a [JIT] ➡ b [JIT]` |

src/components/app/ProfileLoaderAnimation.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ class ProfileLoaderAnimationImpl extends PureComponent<ProfileLoaderAnimationPro
6060
const showLoader = Boolean(loadingMessage);
6161
const showBackHomeLink = Boolean(
6262
'additionalData' in view &&
63-
view.additionalData &&
64-
view.additionalData.message &&
65-
dataSource === 'from-file'
63+
view.additionalData &&
64+
view.additionalData.message &&
65+
dataSource === 'from-file'
6666
);
6767

6868
return (

src/profile-logic/process-profile.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1985,9 +1985,8 @@ export async function unserializeProfileOfArbitraryFormat(
19851985
if (isArtTraceFormat(profileBytes)) {
19861986
arbitraryFormat = convertArtTraceProfile(profileBytes);
19871987
} else if (verifyMagic(SIMPLEPERF_MAGIC, profileBytes)) {
1988-
const { convertSimpleperfTraceProfile } = await import(
1989-
'./import/simpleperf'
1990-
);
1988+
const { convertSimpleperfTraceProfile } =
1989+
await import('./import/simpleperf');
19911990
arbitraryFormat = convertSimpleperfTraceProfile(profileBytes);
19921991
} else {
19931992
try {

src/types/gecko-profile.ts

Lines changed: 26 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,11 @@ export type GeckoSamples = {
140140
// milliseconds since the last event was processed in this
141141
// thread's event loop at the time that the sample was taken
142142
Milliseconds,
143-
// CPU usage value of the current thread.
144-
// It's present only when the CPU Utilization feature is enabled in Firefox.
145-
number | null,
143+
(
144+
// CPU usage value of the current thread.
145+
// It's present only when the CPU Utilization feature is enabled in Firefox.
146+
number | null
147+
),
146148
]
147149
>;
148150
};
@@ -206,19 +208,29 @@ export type GeckoFrameTable = {
206208
IndexIntoStringTable,
207209
// for label frames, whether this frame should be shown in "JS only" stacks
208210
boolean,
209-
// innerWindowID of JS frames. See the comment inside FrameTable in src/types/profile.js
210-
// for more information.
211-
null | number,
211+
(
212+
// innerWindowID of JS frames. See the comment inside FrameTable in src/types/profile.js
213+
// for more information.
214+
null | number
215+
),
212216
// for JS frames, an index into the string table, usually "Baseline" or "Ion"
213217
null | IndexIntoStringTable,
214-
// The line of code
215-
null | number,
216-
// The column of code
217-
null | number,
218-
// index into profile.meta.categories
219-
null | number,
220-
// index into profile.meta.categories[category].subcategories. Always non-null if category is non-null.
221-
null | number,
218+
(
219+
// The line of code
220+
null | number
221+
),
222+
(
223+
// The column of code
224+
null | number
225+
),
226+
(
227+
// index into profile.meta.categories
228+
null | number
229+
),
230+
(
231+
// index into profile.meta.categories[category].subcategories. Always non-null if category is non-null.
232+
null | number
233+
),
222234
]
223235
>;
224236
};

src/utils/query-api.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,7 @@ export interface ExternalCommunicationCallbacks {
120120
*
121121
* It also takes an object with callbacks, for loading indicators.
122122
*/
123-
export class RegularExternalCommunicationDelegate
124-
implements ExternalCommunicationDelegate
125-
{
123+
export class RegularExternalCommunicationDelegate implements ExternalCommunicationDelegate {
126124
_browserConnection: BrowserConnection | null;
127125
_callbacks: ExternalCommunicationCallbacks;
128126

0 commit comments

Comments
 (0)