Skip to content

Commit 5595448

Browse files
committed
Fix the prettier errors
1 parent 30945fb commit 5595448

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

docs-developer/symbolication.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,17 +88,13 @@ Then, the following things happen:
8888
1. [profiler.firefox.com] iterates over all addresses in the profile's call stacks, finds which binary they came from by comparing them to the library information stored in the profile, and converts them into binary-relative offsets.
8989

9090
2. [profiler.firefox.com] checks for which of these libraries it has cached symbol tables in IndexedDB.
91-
9291
1. For libraries with cached symbol tables, it uses those symbol tables to map the addresses to symbols.
9392

9493
3. For all other libraries, it requests symbols for the collected addresses using the Mozilla symbolication API. The results of this are _not_ cached.
95-
9694
1. The Mozilla symbolication API will be able to symbolicate any libraries for which there exist breakpad symbol files on the Mozilla symbol server, so: official Firefox builds, most of Windows system libraries, some macOS system libraries.
9795

9896
4. For any libraries which the Mozilla symbolication API was not able to find symbols, [profiler.firefox.com] requests a symbol table from the add-on, which will forward the request to the geckoProfiler WebExtension API.
99-
10097
1. The WebExtension API will try multiple methods to obtain symbol information. The code for this is at https://searchfox.org/mozilla-central/rev/7e663b9fa578d425684ce2560e5fa2464f504b34/browser/components/extensions/ext-geckoProfiler.js#409-473 .
101-
10298
1. First, it will try to find a breakpad symbol file for the library in the objdir, if the Firefox build that is being symbolicated is a local build. These symbol files only exist if the user has run "mach buildsymbols" after compiling.
10399

104100
2. Next, it will request a raw breakpad symbol file for the library from the Mozilla symbol server. This will never succeed, usually, because if the Mozilla symbol server had information about this library, the Mozilla symbolication API would already have found it. We should probably remove this step.

src/components/shared/FilterNavigatorBar.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,8 @@
220220

221221
/* When the tab selector is active, we want the item to look like a button */
222222
.filterNavigatorBarSelectedItem:has(
223-
button.profileFilterNavigator--tab-selector
224-
) {
223+
button.profileFilterNavigator--tab-selector
224+
) {
225225
background-color: ButtonFace;
226226
color: ButtonText;
227227
}

0 commit comments

Comments
 (0)