Properly type the Map and Set objects (#5623)

I went ahead and checked if the Map or Set objects had unknown types at
the time of their declaration in the language server. These are the
things I found.

This fixes #5617.

Author: mstange

src/actions/profile-view.ts

@@ -1271,9 +1271,10 @@ function _findOtherVisibleThread(
     const localTracks = getLocalTracks(getState(), globalTrack.pid);
     const localTrackOrder = getLocalTrackOrder(getState(), globalTrack.pid);
     const hiddenLocalTracks = getHiddenLocalTracks(getState(), globalTrack.pid);
-    const localTrackIndexesToIgnore = localTrackIndexesToIgnoreByPid
-      ? (localTrackIndexesToIgnoreByPid.get(globalTrack.pid) ?? new Set())
-      : new Set();
+    const localTrackIndexesToIgnore: Set<TrackIndex> =
+      localTrackIndexesToIgnoreByPid
+        ? (localTrackIndexesToIgnoreByPid.get(globalTrack.pid) ?? new Set())
+        : new Set();
 
     for (const trackIndex of localTrackOrder) {
       const track = localTracks[trackIndex];

src/app-logic/url-handling.ts

@@ -635,7 +635,7 @@ function convertHiddenLocalTracksByPidFromString(
     return new Map();
   }
 
-  const hiddenLocalTracksByPid = new Map();
+  const hiddenLocalTracksByPid = new Map<Pid, Set<TrackIndex>>();
 
   for (const stringPart of rawText.split('~')) {
     if (!stringPart.includes('-')) {
@@ -679,7 +679,7 @@ function convertLocalTrackOrderByPidFromString(
     return new Map();
   }
 
-  const localTrackOrderByPid = new Map();
+  const localTrackOrderByPid = new Map<Pid, TrackIndex[]>();
 
   for (const stringPart of rawText.split('~')) {
     if (!stringPart.includes('-')) {
@@ -1018,12 +1018,10 @@ const _upgraders: {
         .join('~');
     }
     if (query.thread) {
-      const selectedThreads = new Set(
+      const selectedThreads = new Set<number>(
         query.thread.split(',').map((n: string) => +n)
       );
-      query.thread = encodeUintSetForUrlComponent(
-        selectedThreads as Set<number>
-      );
+      query.thread = encodeUintSetForUrlComponent(selectedThreads);
     }
 
     // In this version, uintarray-encoding started supporting a range syntax:

src/components/shared/AssemblyView-codemirror.tsx

@@ -149,7 +149,7 @@ function addressTimingsToLineTimings(
   addressTimings: AddressTimings,
   map: AddressToLineMap
 ): LineTimings {
-  const totalLineHits = new Map();
+  const totalLineHits = new Map<LineNumber, number>();
   for (const [address, hitCount] of addressTimings.totalAddressHits) {
     const line = map.addressToLine(address);
     if (line !== null) {
@@ -158,7 +158,7 @@ function addressTimingsToLineTimings(
     }
   }
 
-  const selfLineHits = new Map();
+  const selfLineHits = new Map<LineNumber, number>();
   for (const [address, hitCount] of addressTimings.selfAddressHits) {
     const line = map.addressToLine(address);
     if (line !== null) {

src/components/tooltip/GCMarker.tsx

@@ -466,7 +466,7 @@ function _filterInterestingPhaseTimes(
   /*
    * Build the tree.
    */
-  const tree = new Map();
+  const tree = new Map<string, PhaseTreeNode>();
   for (const phase of phaseTimes) {
     const components = phase.name.split('.');
     _treeInsert(tree, components, phase);

src/profile-logic/call-node-info.ts

@@ -1161,7 +1161,7 @@ export class CallNodeInfoInverted implements CallNodeInfo {
     // Pass 1: Count the deep nodes per func, and build up a list of funcs.
     // We will need to create a child for each deep node func, and each child will
     // need to know how many deep nodes it has.
-    const deepNodeCountPerFunc = new Map();
+    const deepNodeCountPerFunc = new Map<IndexIntoFuncTable, number>();
     const callNodeTable = this._callNodeTable;
     for (let i = 0; i < parentDeepNodeCount; i++) {
       const selfNode = parentSelfNodes[i];
@@ -1212,7 +1212,7 @@ export class CallNodeInfoInverted implements CallNodeInfo {
     // partitions; one partition per child, in the right order.
     const startIndexPerChild = new Uint32Array(childCount);
     const deepNodeCountPerChild = new Uint32Array(childCount);
-    const funcToChildIndex = new Map();
+    const funcToChildIndex = new Map<IndexIntoFuncTable, number>();
 
     let nextChildStartIndex = 0;
     for (let childIndex = 0; childIndex < childCount; childIndex++) {

src/profile-logic/import/art-trace.ts

@@ -3,6 +3,11 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 // Parses the ART trace format and converts it to the Gecko profile format.
 
+import type {
+  IndexIntoFrameTable,
+  IndexIntoStackTable,
+} from 'firefox-profiler/types';
+
 // These profiles are obtained from Android in two ways:
 //  - Programmatically, from the Debug API: https://developer.android.com/studio/profile/cpu-profiler#debug-api
 //  - Or via the profiler UI in Android Studio.
@@ -566,7 +571,7 @@ function procureSamplingInterval(trace: ArtTrace) {
 
   // Gather up to 500 time deltas between method actions on a thread.
   const deltas: number[] = [];
-  const previousTimestampByThread = new Map();
+  const previousTimestampByThread = new Map<number, number>();
   const numberOfActionsToConsider = Math.min(500, methodActions.length);
   for (let i = 0; i < numberOfActionsToConsider; i++) {
     const { tid, globalTime } = methodActions[i];
@@ -621,7 +626,7 @@ export function getSpecialCategory(
     return s.substring(0, firstPeriodPos);
   }
 
-  const significantSegmentCounter = new Map();
+  const significantSegmentCounter = new Map<string, number>();
   for (let i = 0; i < methods.length; i++) {
     const significantSegment = getSignificantNamespaceSegment(
       methods[i].className
@@ -791,8 +796,8 @@ class ThreadBuilder {
 
   _currentStack: number | null = null;
   _nextSampleTimestamp = 0;
-  _stackMap = new Map();
-  _frameMap = new Map();
+  _stackMap = new Map<string, IndexIntoStackTable>();
+  _frameMap = new Map<number, IndexIntoFrameTable>();
   _registerTime = 0;
   _name;
   _pid;
@@ -943,7 +948,7 @@ export function convertArtTraceProfile(
   const { summaryDetails, threads, methods, methodActions } = trace;
   const categoryInfo = new CategoryInfo(methods);
   const methodMap = new Map(methods.map((m) => [m.methodId, m]));
-  const threadBuilderMap = new Map();
+  const threadBuilderMap = new Map<number, ThreadBuilder>();
 
   if (methodActions.length > 0) {
     for (let i = 0; i < methodActions.length; i++) {

src/profile-logic/import/chrome.ts

@@ -396,10 +396,10 @@ function getThreadInfo(
 
   profile.threads.push(thread);
 
-  const nodeIdToStackId = new Map();
+  const nodeIdToStackId = new Map<number | void, IndexIntoStackTable | null>();
   nodeIdToStackId.set(undefined, null);
 
-  const threadInfo = {
+  const threadInfo: ThreadInfo = {
     thread,
     nodeIdToStackId,
     funcKeyToFuncId: new Map(),
@@ -518,8 +518,8 @@ async function processTracingEvents(
     ensureExists(profile.meta.categories)
   );
 
-  const threadInfoByPidAndTid = new Map();
-  const threadInfoByThread = new Map();
+  const threadInfoByPidAndTid = new Map<string, ThreadInfo>();
+  const threadInfoByThread = new Map<RawThread, ThreadInfo>();
   for (const profileEvent of profileEvents) {
     // The thread info is all of the data that makes it possible to process an
     // individual thread.
@@ -574,7 +574,7 @@ async function processTracingEvents(
       } = thread;
 
       if (nodes) {
-        const parentMap = new Map();
+        const parentMap = new Map<number, number>();
         for (const node of nodes) {
           const { callFrame, id: nodeIndex } = node;
           let parent: number | void = undefined;

src/profile-logic/import/linux-perf.ts

@@ -2,7 +2,11 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-import type { MixedObject } from 'firefox-profiler/types';
+import type {
+  IndexIntoFrameTable,
+  IndexIntoStackTable,
+  MixedObject,
+} from 'firefox-profiler/types';
 
 /**
  * The "perf script" format is the plain text format that is output by an
@@ -118,7 +122,7 @@ export function convertPerfScriptProfile(
     };
     const stringTable: string[] = [];
 
-    const stackMap = new Map();
+    const stackMap = new Map<string, IndexIntoStackTable>();
     function getOrCreateStack(frame: number, prefix: number | null) {
       const key = prefix === null ? `${frame}` : `${frame},${prefix}`;
       let stack = stackMap.get(key);
@@ -130,7 +134,7 @@ export function convertPerfScriptProfile(
       return stack;
     }
 
-    const frameMap = new Map();
+    const frameMap = new Map<string, IndexIntoFrameTable>();
     function getOrCreateFrame(frameString: string): number {
       let frame = frameMap.get(frameString);
       if (frame === undefined) {

src/profile-logic/js-tracer.tsx

@@ -38,7 +38,7 @@ function getScriptLocationToFuncIndex(
   sources: SourceTable
 ): ScriptLocationToFuncIndex {
   const { funcTable } = thread;
-  const scriptLocationToFuncIndex = new Map();
+  const scriptLocationToFuncIndex: ScriptLocationToFuncIndex = new Map();
   for (let funcIndex = 0; funcIndex < funcTable.length; funcIndex++) {
     if (!funcTable.isJS[funcIndex]) {
       continue;

src/profile-logic/marker-data.ts

@@ -484,7 +484,7 @@ export function correlateIPCMarkers(
       recvThreadName: formatThreadName(recvTid),
     };
 
-    const addedThreadIds = new Set();
+    const addedThreadIds = new Set<number>();
     if (startEndpointMarker) {
       addedThreadIds.add(startEndpointMarker.tid);
       correlations.set(
@@ -1331,7 +1331,7 @@ export function groupScreenshotsById(
   getMarker: (markerIndex: MarkerIndex) => Marker,
   markerIndexes: MarkerIndex[]
 ): Map<string, Marker[]> {
-  const idToScreenshotMarkers = new Map();
+  const idToScreenshotMarkers = new Map<string, Marker[]>();
   for (const markerIndex of markerIndexes) {
     const marker = getMarker(markerIndex);
     const { data } = marker;