Enable noUnusedParameters and @typescript-eslint/no-unused-vars and clean up a few more things (#5576)

Author: canova

eslint.config.mjs

@@ -140,14 +140,25 @@ export default [
       'no-else-return': 'error',
       'no-nested-ternary': 'error',
 
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        {
+          args: 'all',
+          argsIgnorePattern: '^_',
+          caughtErrors: 'all',
+          caughtErrorsIgnorePattern: '^_',
+          destructuredArrayIgnorePattern: '^_',
+          varsIgnorePattern: '^_',
+          ignoreRestSiblings: true,
+        },
+      ],
+
       // Use `import type` everywhere we can.
       '@typescript-eslint/consistent-type-imports': 'error',
       // Allow `as any` escape hatches
       '@typescript-eslint/no-explicit-any': 'off',
       // Disable a rule that the TypeScript FAQ disapproves of
       '@typescript-eslint/no-empty-object-type': 'off',
-      // Should enable this soon, mostly finds `catch (e)` with unused e
-      '@typescript-eslint/no-unused-vars': 'off',
       // TypeScript imports react-jsx into .tsx files for us
       'react/react-in-jsx-scope': 'off',
       // Allow @ts-expect-error annotations with descriptions.

profile-server.js

@@ -8,7 +8,7 @@ const path = require('path');
 module.exports = {
   serveAndOpen(host, profilerUrl, profilePath, openOptions) {
     // Create a simple http server serving the profile file.
-    const profileServer = http.createServer((req, res) => {
+    const profileServer = http.createServer((_req, res) => {
       res.setHeader('Access-Control-Allow-Origin', profilerUrl);
       const fileStream = fs.createReadStream(profilePath);
       fileStream.pipe(res);

src/app-logic/create-store.ts

@@ -18,7 +18,7 @@ export default function initializeStore(): Store {
   if (process.env.NODE_ENV === 'development') {
     loggerMiddleware = createLogger({
       collapsed: true,
-      titleFormatter: (action, time, duration) =>
+      titleFormatter: (action, _time, duration) =>
         `[action]    ${action.type} (in ${duration.toFixed(2)} ms)`,
       logErrors: false,
       duration: true,

src/components/app/AppLocalizationProvider.tsx

@@ -137,7 +137,7 @@ class AppLocalizationInit extends React.PureComponent<InitProps> {
         console.warn(
           `The stored locale information (${strPreviouslyRequestedLocales}) looks incorrect.`
         );
-      } catch (e) {
+      } catch (_e) {
         console.warn(
           `We got an error when trying to parse the previously stored locale information (${strPreviouslyRequestedLocales}).`
         );

src/components/app/CodeLoadingOverlay.tsx

@@ -17,7 +17,7 @@ export function CodeLoadingOverlay({ source }: CodeLoadingOverlayProps) {
       let host;
       try {
         host = new URL(url).host;
-      } catch (e) {
+      } catch (_e) {
         host = url;
       }
       return (

src/components/flame-graph/Canvas.tsx

@@ -422,7 +422,6 @@ class FlameGraphCanvasImpl extends React.PureComponent<Props> {
             ? this._getTimingsForCallNodeIndex(
                 callNodeIndex,
                 callNodeInfo,
-                interval,
                 unfilteredThread,
                 ctssSampleIndexOffset,
                 categories,

src/components/network-chart/NetworkChartRow.tsx

@@ -380,7 +380,7 @@ export class NetworkChartRow extends React.PureComponent<
     try {
       const uri = new URL(this._cropNameToUrl(url));
       return uri;
-    } catch (e) {
+    } catch (_e) {
       return null;
     }
   }

src/components/shared/AssemblyView-codemirror.tsx

@@ -29,7 +29,6 @@ import type {
   Address,
   LineTimings,
   LineNumber,
-  NativeSymbolInfo,
   DecodedInstruction,
 } from 'firefox-profiler/types';
 
@@ -179,7 +178,6 @@ export class AssemblyViewEditor {
   // Create a CodeMirror editor and add it as a child element of domParent.
   constructor(
     initialAssemblyCode: DecodedInstruction[],
-    nativeSymbol: NativeSymbolInfo,
     addressTimings: AddressTimings,
     domParent: Element
   ) {

src/components/shared/AssemblyView.tsx

@@ -149,7 +149,6 @@ export class AssemblyView extends React.PureComponent<AssemblyViewProps> {
       const { AssemblyViewEditor } = codeMirrorModule;
       const editor = new AssemblyViewEditor(
         this._getAssemblyCodeOrFallback(),
-        this.props.nativeSymbol,
         this.props.timings,
         domParent
       );

src/components/shared/ButtonWithPanel/ArrowPanel.tsx

@@ -89,7 +89,7 @@ export class ArrowPanel extends React.PureComponent<Props, State> {
 
   // We're calling open and close callbacks in componentDidUpdate because they
   // often run side-effects, so we want them out of the render phase.
-  override componentDidUpdate(prevProps: Props, prevState: State) {
+  override componentDidUpdate(_prevProps: Props, prevState: State) {
     if (!prevState.open && this.state.open) {
       // Opening
       this.props.onOpen();