Skip to content

Commit b3a786c

Browse files
committed
Remove the eslint rule that allows @ts-nocheck in test files
Now that we removed the last @ts-nocheck from the src/test directory, we can remove that eslint rule that allows it. Ideally we shouldn't need to add that ts comment anymore.
1 parent 7bda1ee commit b3a786c

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

eslint.config.mjs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -215,22 +215,6 @@ export default [
215215
// Allow require(), for example for importing JSON files.
216216
'@typescript-eslint/no-require-imports': 'off',
217217

218-
// Override the project-wide config to allow @ts-nocheck.
219-
// We really just need this for our mocks.
220-
'@typescript-eslint/ban-ts-comment': [
221-
'error',
222-
{
223-
// Allow @ts-expect-error and @ts-no-check annotations with descriptions.
224-
'ts-expect-error': 'allow-with-description',
225-
'ts-nocheck': 'allow-with-description',
226-
// Don't allow @ts-ignore because we want to be notified
227-
// when the error goes away so we can remove the annotation - use
228-
// @ts-expect-error instead
229-
'ts-ignore': true,
230-
'ts-check': false,
231-
},
232-
],
233-
234218
// Adding more errors now
235219
'testing-library/no-manual-cleanup': 'error',
236220
'testing-library/no-wait-for-snapshot': 'error',

0 commit comments

Comments
 (0)