Commit cb32d51
committed
Remove the unneeded @babel/no-invalid-this eslint disable rule
It looks like this line was a false positive for @babel/no-invalid-this
initially because here `this` comes from a parameter and it's not a
global `this`. After we upgraded the eslint version, this is correctly
caught and not reported as error.
I double checked this rule, by specifically making this mistake in the
codebase, and it looks like we catch it properly elsewhere, so it's not
a case where we fail to detect this rule.
This is the explanation of that rule:
https://eslint.org/docs/latest/rules/no-invalid-this
I explicitly tried the first incorrect example here and `yarn lint-js`
catches it properly.1 parent c57078e commit cb32d51
1 file changed
+0
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
440 | | - | |
441 | 440 | | |
442 | 441 | | |
443 | 442 | | |
| |||
0 commit comments