Bugfix/handle submenu callback (#287)

* Handle the case where submenu is missing

* Unit test callback crashing fix

* Updated cleanup to exit early when submenu is gone

Author: juskevicius

src/SubMenu.js

@@ -68,6 +68,7 @@ export default class SubMenu extends AbstractMenu {
         if (this.props.forceOpen || this.state.visible) {
             const wrapper = window.requestAnimationFrame || setTimeout;
             wrapper(() => {
+                if (!this.subMenu) return;
                 const styles = this.props.rtl
                     ? this.getRTLMenuPosition()
                     : this.getMenuPosition();
@@ -88,6 +89,7 @@ export default class SubMenu extends AbstractMenu {
             });
         } else {
             const cleanup = () => {
+                if (!this.subMenu) return;
                 this.subMenu.removeEventListener('transitionend', cleanup);
                 this.subMenu.style.removeProperty('bottom');
                 this.subMenu.style.removeProperty('right');

tests/SubMenu.test.js

@@ -42,4 +42,19 @@ describe('<SubMenu/>', () => {
         await user.hover(wrapper);
         await expect(() => waitForMenuVisible(submenu)).rejects.toThrow();
     });
+
+    it('should not crash after immediate unmount', async () => {
+        let callback = null;
+        jest.spyOn(window, 'requestAnimationFrame').mockImplementation((cb) => {
+            callback = cb;
+            return 1;
+        });
+        const { unmount } = render(<SubMenu title='Title' hoverDelay={0} />);
+        const user = userEvent.setup();
+        const wrapper = screen.getByText('Title');
+        await user.hover(wrapper);
+        unmount();
+
+        expect(callback).not.toThrow();
+    });
 });