Skip to content

Commit 5ecc0dc

Browse files
committed
Move from the deprecated keyCode to key for keyboard events
1 parent 4fc7c40 commit 5ecc0dc

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

src/AbstractMenu.js

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,24 +25,29 @@ export default class AbstractMenu extends Component {
2525
return;
2626
}
2727

28-
switch (e.keyCode) {
29-
case 37: // left arrow
30-
case 27: // escape
28+
switch (e.key) {
29+
case 'ArrowLeft': // left arrow
30+
case 'Left': // IE specific value
31+
case 'Escape': // escape
32+
case 'Esc': // IE specific value
3133
e.preventDefault();
3234
this.hideMenu(e);
3335
break;
34-
case 38: // up arrow
36+
case 'ArrowUp': // up arrow
37+
case 'Up': // IE specific value
3538
e.preventDefault();
3639
this.selectChildren(true);
3740
break;
38-
case 40: // down arrow
41+
case 'ArrowDown': // down arrow
42+
case 'Down': // IE specific value
3943
e.preventDefault();
4044
this.selectChildren(false);
4145
break;
42-
case 39: // right arrow
46+
case 'ArrowRight': // right arrow
47+
case 'Right': // IE specific value
4348
this.tryToOpenSubMenu(e);
4449
break;
45-
case 13: // enter
50+
case 'Enter': // enter
4651
e.preventDefault();
4752
this.tryToOpenSubMenu(e);
4853
{

src/ContextMenu.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ export default class ContextMenu extends AbstractMenu {
170170
// Disabling this rule for more consistency.
171171
/* eslint-disable-next-line class-methods-use-this */
172172
hideMenu = (e) => {
173-
if (e.keyCode === 27 || e.keyCode === 13) { // ECS or enter
173+
if (e.key === 'Escape' || e.key === 'Esc' || e.key === 'Enter') {
174174
hideMenu();
175175
}
176176
};

0 commit comments

Comments
 (0)