Fix build automations

Update checkout and artifact versions
GPG key import mechanism reworked and using a functional server
Fix deprecated environment use

Author: philwhineray

.github/workflows/publish.yml

@@ -8,8 +8,8 @@ jobs:
       - name: Extract tag/branch variables
         shell: bash
         run: |
-           echo "##[set-output name=tag;]$(echo ${GITHUB_REF#refs/tags/}|grep -v '/')"
-           echo "##[set-output name=branch;]$(echo ${GITHUB_REF#refs/heads/}|grep -v '/')"
+           echo "tag=$(echo ${GITHUB_REF#refs/tags/}|grep -v '/')" >> $GITHUB_OUTPUT
+           echo "branch=$(echo ${GITHUB_REF#refs/heads/}|grep -v '/')" >> $GITHUB_OUTPUT
         id: extract
       outputs:
          tag: ${{ steps.extract.outputs.tag }}
@@ -20,7 +20,7 @@ jobs:
       name: Build package
       needs: prep
       steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Set up build tools
         run: ./.github/workflows/setup.sh
       - name: Server-side run of commit hooks in case developer skipped them
@@ -34,7 +34,7 @@ jobs:
             ./packaging/gpg-recv-key [email protected] "4DFF 624A E564 3B51 2872  1F40 29CA 3358 89B9 A863"
             git fetch --tags -f
         env:
-           KEYSERVER: pool.sks-keyservers.net
+           KEYURL: https://keyserver.ubuntu.com/pks/lookup?exact=on&op=get&search=
       - name: Run build
         run: fakeroot ./packaging/git-build && ./configure && make check
         env:
@@ -47,7 +47,7 @@ jobs:
               sha512sum -b $i > $i.sha
            done
       - name: Upload build artifacts
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
            name: build-artifacts
            path: |
@@ -69,7 +69,7 @@ jobs:
             || startsWith( needs.prep.outputs.branch, 'stable-' ) ) }}
       steps:
       - name: Download artifacts
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4.1.7
         with:
            name: build-artifacts
       - name: Setup SSH
@@ -80,8 +80,8 @@ jobs:
            eval "$(ssh-agent)"
            if ssh-add firehol_org_publish_key; then
               echo "Key added: setting agent environment"
-              echo "##[set-output name=ssh_agent_pid;]$SSH_AGENT_PID"
-              echo "##[set-output name=ssh_auth_sock;]$SSH_AUTH_SOCK"
+              echo "ssh_agent_pid=$SSH_AGENT_PID" >> $GITHUB_OUTPUT
+              echo "ssh_auth_sock=$SSH_AUTH_SOCK" >> $GITHUB_OUTPUT
               mkdir -p $HOME/.ssh
               chmod 700 $HOME/.ssh
               echo PasswordAuthentication=no >> $HOME/.ssh/config
@@ -135,7 +135,7 @@ jobs:
       if: ${{ needs.prep.outputs.tag != '' }}
       steps:
       - name: Download artifacts
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4.1.7
         with:
            name: build-artifacts
       - name: Create Release

packaging/gpg-recv-key

@@ -1,9 +1,9 @@
 #!/bin/sh
 
-if [ ! "$KEYSERVER" ]
+if [ ! "$KEYURL" ]
 then
-  echo "No KEYSERVER environment set, e.g.:"
-  echo "  export KEYSERVER=hkps://hkps.pool.sks-keyservers.net"
+  echo "No KEYURL environment set, e.g.:"
+  echo "  export KEYURL='https://keyserver.ubuntu.com/pks/lookup?exact=on&op=get&search='"
   exit 1
 fi
 
@@ -30,9 +30,10 @@ fingerprint="$2"
 # Modern GPG can import key by fingerprint but the version available
 # within travis currently does not, so we extract the short version and
 # check it matches manually
-key=`echo $fingerprint | cut -f7-10 -d' ' | tr -d ' '`
+key=`echo $fingerprint | tr -d ' '`
 
-gpg --keyserver "$KEYSERVER" --recv-key "$key" || exit 1
+curl -o/tmp/keydata.asc "${KEYURL}0x$key" || exit 1
+gpg --import /tmp/keydata.asc || exit 1
 gpg --fingerprint "$key" > /tmp/keystatus.$$
 status=$?