-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
Hey!
Thanks for a great library!
If I'm not incorrect I think this part:
/^(?:[0-1][0-9]|2[0-3])(:|;)(?:[0-5][0-9])\1(?:[0-5][0-9])(:|;)(?:[0-2][0-9])$/.test(timecode);
should be changed to:
/^(?:[0-1][0-9]|2[0-3])(:|;)(?:[0-5][0-9])\1(?:[0-5][0-9])(:|;)(?:[0-5][0-9])$/.test(timecode);
to support frame rates from 30 and over.
Or make that value dynamic based on frame rate to be even more precise.
Thanks again!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels