Skip to content

Error with frame rates 30-60 #30

@seabasss

Description

@seabasss

Hey!

Thanks for a great library!

If I'm not incorrect I think this part:
/^(?:[0-1][0-9]|2[0-3])(:|;)(?:[0-5][0-9])\1(?:[0-5][0-9])(:|;)(?:[0-2][0-9])$/.test(timecode);
should be changed to:
/^(?:[0-1][0-9]|2[0-3])(:|;)(?:[0-5][0-9])\1(?:[0-5][0-9])(:|;)(?:[0-5][0-9])$/.test(timecode);
to support frame rates from 30 and over.

Or make that value dynamic based on frame rate to be even more precise.

Thanks again!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions