Merge pull request #186 from firmata/analog-reporting-fix

prevent analog reporting during system reset

Author: soundanalogous

examples/StandardFirmata/StandardFirmata.ino

@@ -77,6 +77,8 @@ struct i2c_device_info {
 /* for i2c read continuous more */
 i2c_device_info query[MAX_QUERIES];
 
+boolean isResetting = false;
+
 byte i2cRxData[32];
 boolean isI2CEnabled = false;
 signed char queryIndex = -1;
@@ -349,10 +351,14 @@ void reportAnalogCallback(byte analogPin, int value)
       analogInputsToReport = analogInputsToReport & ~ (1 << analogPin);
     } else {
       analogInputsToReport = analogInputsToReport | (1 << analogPin);
-      // Send pin value immediately. This is helpful when connected via
-      // ethernet, wi-fi or bluetooth so pin states can be known upon
-      // reconnecting.
-      Firmata.sendAnalog(analogPin, analogRead(analogPin));
+      // prevent during system reset or all analog pin values will be reported
+      // which may report noise for unconnected analog pins
+      if (!isResetting) {
+        // Send pin value immediately. This is helpful when connected via
+        // ethernet, wi-fi or bluetooth so pin states can be known upon
+        // reconnecting.
+        Firmata.sendAnalog(analogPin, analogRead(analogPin));
+      }
     }
   }
   // TODO: save status to EEPROM here, if changed
@@ -610,6 +616,7 @@ void disableI2CPins() {
 
 void systemResetCallback()
 {
+  isResetting = true;
   // initialize a defalt state
   // TODO: option to load config from EEPROM instead of default
   if (isI2CEnabled) {
@@ -650,6 +657,7 @@ void systemResetCallback()
     outputPort(i, readPort(i, portConfigInputs[i]), true);
   }
   */
+  isResetting = false;
 }
 
 void setup()

examples/StandardFirmataYun/StandardFirmataYun.ino

@@ -78,6 +78,8 @@ struct i2c_device_info {
 /* for i2c read continuous more */
 i2c_device_info query[MAX_QUERIES];
 
+boolean isResetting = false;
+
 byte i2cRxData[32];
 boolean isI2CEnabled = false;
 signed char queryIndex = -1;
@@ -355,13 +357,16 @@ void reportAnalogCallback(byte analogPin, int value)
   if (analogPin < TOTAL_ANALOG_PINS) {
     if (value == 0) {
       analogInputsToReport = analogInputsToReport & ~ (1 << analogPin);
-    }
-    else {
+    } else {
       analogInputsToReport = analogInputsToReport | (1 << analogPin);
-      // Send pin value immediately. This is helpful when connected via
-      // ethernet, wi-fi or bluetooth so pin states can be known upon
-      // reconnecting.
-      Firmata.sendAnalog(analogPin, analogRead(analogPin));
+      // prevent during system reset or all analog pin values will be reported
+      // which may report noise for unconnected analog pins
+      if (!isResetting) {
+        // Send pin value immediately. This is helpful when connected via
+        // ethernet, wi-fi or bluetooth so pin states can be known upon
+        // reconnecting.
+        Firmata.sendAnalog(analogPin, analogRead(analogPin));
+      }
     }
   }
   // TODO: save status to EEPROM here, if changed
@@ -621,6 +626,7 @@ void disableI2CPins() {
 
 void systemResetCallback()
 {
+  isResetting = true;
   // initialize a defalt state
   // TODO: option to load config from EEPROM instead of default
   if (isI2CEnabled) {
@@ -662,6 +668,7 @@ void systemResetCallback()
    outputPort(i, readPort(i, portConfigInputs[i]), true);
    }
    */
+  isResetting = false;
 }
 
 void setup()

extras/revisions.txt

@@ -3,6 +3,9 @@ FIRMATA 2.4.1 - Feb 7, 2015
 [core library]
 * Fixed off-by-one bug in setFirmwareNameAndVersion (Brian Schmalz)
 
+[StandardFirmata]
+* Prevent analog values from being reported during system reset
+
 FIRMATA 2.4.0 - Dec 21, 2014
 
 Changes from 2.3.6 to 2.4 that may impact existing Firmata client implementations: