Skip to content

Commit e6a09e5

Browse files
committed
most remaining absolte pin numbers/counts replaced by defines/constants from pins_arduino.h
1 parent a375d3a commit e6a09e5

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

Boards.h

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -666,24 +666,23 @@ writePort(port, value, bitmask): Write an 8 bit port.
666666
#define PIN_TO_SERVO(p) ((p) - 2)
667667

668668
// ESP8266
669-
// hardware: TX0=1, TX1=2, RX0=3, MISO=12, MOSI=13, SCLK=14, CS=15, A0=17
670-
// board depended defaults: LED_BUILTIN, SDA, SCL
671-
// note: boot mode GPIOs 0, 2 and 15 can be used as outputs (GPIOs 6-11 are in use for flash IO)
669+
// note: boot mode GPIOs 0, 2 and 15 can be used as outputs, GPIOs 6-11 are in use for flash IO
672670
#elif defined(ESP8266)
673-
#define TOTAL_ANALOG_PINS 1
674-
#define TOTAL_PINS 18 // 11 digital + 1 analog + 6 inaccessible
671+
#define TOTAL_ANALOG_PINS NUM_ANALOG_INPUTS
672+
#define TOTAL_PINS (NUM_DIGITAL_PINS > A0 + NUM_ANALOG_INPUTS ? NUM_DIGITAL_PINS : A0 + NUM_ANALOG_INPUTS)
673+
#define VERSION_BLINK_PIN LED_BUILTIN
675674
#define PIN_SERIAL_RX 3
676675
#define PIN_SERIAL_TX 1
677-
#define IS_PIN_DIGITAL(p) (((p) >= 0 && (p) <= 5) || ((p) >= 12 && (p) <= 16))
678-
#define IS_PIN_ANALOG(p) ((p) == A0)
676+
#define IS_PIN_DIGITAL(p) (((p) >= 0 && (p) <= 5) || ((p) >= 12 && (p) < (NUM_DIGITAL_PINS > A0 + NUM_ANALOG_INPUTS ? NUM_DIGITAL_PINS : A0)))
677+
#define IS_PIN_ANALOG(p) ((p) >= A0 && (p) < A0 + NUM_ANALOG_INPUTS)
679678
#define IS_PIN_PWM(p) IS_PIN_DIGITAL(p)
680679
#define IS_PIN_SERVO(p) (IS_PIN_DIGITAL(p) && (p) < MAX_SERVOS)
681680
#define IS_PIN_I2C(p) ((p) == SDA || (p) == SCL)
682-
#define IS_PIN_SPI(p) ((p) >= 12 && (p) <= 15)
683-
#define IS_PIN_INTERRUPT(p) (((p) >= 0 && (p) <= 5) || ((p) >= 12 && (p) <= 15))
684-
#define IS_PIN_SERIAL(p) ((p) == 1 || (p) == 3)
681+
#define IS_PIN_SPI(p) ((p) == SS || (p) == MOSI || (p) == MISO || (p) == SCK)
682+
#define IS_PIN_INTERRUPT(p) digitalPinToInterrupt(p)
683+
#define IS_PIN_SERIAL(p) ((p) == PIN_SERIAL_RX || (p) == PIN_SERIAL_TX)
685684
#define PIN_TO_DIGITAL(p) (p)
686-
#define PIN_TO_ANALOG(p) ((p) - 17)
685+
#define PIN_TO_ANALOG(p) ((p) - A0)
687686
#define PIN_TO_PWM(p) PIN_TO_DIGITAL(p)
688687
#define PIN_TO_SERVO(p) (p)
689688

0 commit comments

Comments
 (0)