Skip to content

Commit dc345c2

Browse files
committed
refactor: removing in-line styling
Replacing in-line styling with class-based styling for best-practice
1 parent e13f0c1 commit dc345c2

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

src/components/ProjectList/CardsContainer.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,8 @@ export default class CardsContainer extends React.Component {
128128
onChange={this.handleSelectChange}
129129
options={this.filterOptions}
130130
multi={true}
131-
placeholder={<div className='filter-placeholder-text' style={{color: "#757575"}}>Filter</div>}
131+
placeholder={<div className='filter-placeholder-text'>Filter</div>}
132132
aria-labelledby='tag-selector-container'
133-
style={{borderColor: "#DCDCDC"}}
134133
/>
135134
</div>
136135
</div>
@@ -144,6 +143,7 @@ export default class CardsContainer extends React.Component {
144143
projectLink={item.projectLink}
145144
description={item.description}
146145
tags={item.tags}
146+
className='testing-testing'
147147
/>
148148
);
149149
})}

src/components/ProjectList/ProjectsCards.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const Card = ({
2727
alt="the framework or language that the project is build upon"
2828
src={logoLink}
2929
/>
30-
<p style={{fontSize: 20}} className="Card-Title">{name}</p>
30+
<p className="Card-Title">{name}</p>
3131
</div>
3232
<div className="Card-Body">
3333
<div className="Card-Tag">{tags}</div>

src/components/ProjectList/css/project-cards.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
.Card-Title {
8080
margin-top: 6%;
8181
height: 10%;
82+
font-size: 20px;
8283
}
8384
.Card-Link-Style {
8485
margin-left: 10%;

0 commit comments

Comments
 (0)