Add tests for send_command

Author: firstof9

openevsehttp/__init__.py

@@ -47,16 +47,16 @@ def __init__(self, host: str, user: str = None, pwd: str = None) -> None:
         self._status = None
         self._config = None
 
-    async def send_command(self, command: str) -> tuple | None:
+    def send_command(self, command: str) -> tuple | None:
         """Send a command via HTTP to the charger and prases the response."""
         url = f"{self._url}/r?json=1"
         data = {"rapi": command}
 
         _LOGGER.debug("Posting data: %s to %s", command, url)
         if self._user is not None:
-            value = requests.get(url, data=data, auth=(self._user, self._pwd))
+            value = requests.post(url, data=data, auth=(self._user, self._pwd))
         else:
-            value = requests.get(url, data=data)
+            value = requests.post(url, data=data)
 
         if value.status_code == 400:
             raise ParseJSONError
@@ -66,7 +66,7 @@ async def send_command(self, command: str) -> tuple | None:
         if "ret" not in value.json():
             return False, ""
         resp = value.json()
-        return resp[0] == "OK", resp[1:]
+        return resp["cmd"] == "OK", resp["ret"]
 
     def update(self) -> None:
         """Update the values."""

tests/conftest.py

@@ -1,5 +1,6 @@
 """Provide common pytest fixtures."""
 import pytest
+import json
 
 import openevsehttp
 from tests.common import load_fixture
@@ -85,3 +86,41 @@ def mock_config_v2(requests_mock):
         "http://openevse.test.tld/config",
         text=load_fixture("v2_json/config.json"),
     )
+
+
+@pytest.fixture(name="send_command_mock")
+def mock_send_command(requests_mock):
+    """Mock the command reply."""
+    value = {"cmd": "OK", "ret": "test"}
+    requests_mock.post(
+        "http://openevse.test.tld/r?json=1",
+        text=json.dumps(value),
+    )
+
+
+@pytest.fixture(name="send_command_parse_err")
+def mock_send_command_parse_err(requests_mock):
+    """Mock the command reply parse err."""
+    requests_mock.post(
+        "http://openevse.test.tld/r?json=1",
+        status_code=400,
+    )
+
+
+@pytest.fixture(name="send_command_auth_err")
+def mock_send_command_auth_err(requests_mock):
+    """Mock the command reply auth err."""
+    requests_mock.post(
+        "http://openevse.test.tld/r?json=1",
+        status_code=401,
+    )
+
+
+@pytest.fixture(name="send_command_mock_missing")
+def mock_send_command_missing(requests_mock):
+    """Mock the command reply."""
+    value = {"cmd": "OK", "what": "test"}
+    requests_mock.post(
+        "http://openevse.test.tld/r?json=1",
+        text=json.dumps(value),
+    )

tests/test_init.py

@@ -16,6 +16,38 @@ def test_get_status_auth_err(test_charger_auth_err):
         assert test_charger_auth_err is None
 
 
+def test_send_command(test_charger, send_command_mock):
+    """Test v4 Status reply"""
+    status = test_charger.send_command("test")
+    assert status == (True, "test")
+
+
+def test_send_command_missing(test_charger, send_command_mock_missing):
+    """Test v4 Status reply"""
+    status = test_charger.send_command("test")
+    assert status == (False, "")
+
+
+def test_send_command_auth(test_charger_auth, send_command_mock):
+    """Test v4 Status reply"""
+    status = test_charger_auth.send_command("test")
+    assert status == (True, "test")
+
+
+def test_send_command_parse_err(test_charger_auth, send_command_parse_err):
+    """Test v4 Status reply"""
+    with pytest.raises(openevsehttp.ParseJSONError):
+        status = test_charger_auth.send_command("test")
+        assert status is None
+
+
+def test_send_command_auth_err(test_charger_auth, send_command_auth_err):
+    """Test v4 Status reply"""
+    with pytest.raises(openevsehttp.AuthenticationError):
+        status = test_charger_auth.send_command("test")
+        assert status is None
+
+
 @pytest.mark.parametrize(
     "fixture, expected",
     [("test_charger", "sleeping"), ("test_charger_v2", "not connected")],