Skip to content

Commit 7d78cb0

Browse files
committed
Fix weird lifetime
- There is no reason for the replacement to share lifetime with the subject, because the replacement is not present in the return value, even if no replacement occured
1 parent 515382f commit 7d78cb0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/regex_impl.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,7 @@ impl<W: CodeUnitWidth> Regex<W> {
501501
pub fn replace<'s>(
502502
&self,
503503
subject: &'s [W::SubjectChar],
504-
replacement: &'s [W::SubjectChar],
504+
replacement: &[W::SubjectChar],
505505
extended: bool,
506506
) -> Result<Cow<'s, [W::SubjectChar]>, Error>
507507
where
@@ -515,7 +515,7 @@ impl<W: CodeUnitWidth> Regex<W> {
515515
pub fn replace_all<'s>(
516516
&self,
517517
subject: &'s [W::SubjectChar],
518-
replacement: &'s [W::SubjectChar],
518+
replacement: &[W::SubjectChar],
519519
extended: bool,
520520
) -> Result<Cow<'s, [W::SubjectChar]>, Error>
521521
where
@@ -528,7 +528,7 @@ impl<W: CodeUnitWidth> Regex<W> {
528528
fn replace_impl<'s>(
529529
&self,
530530
subject: &'s [W::SubjectChar],
531-
replacement: &'s [W::SubjectChar],
531+
replacement: &[W::SubjectChar],
532532
replace_all: bool,
533533
extended: bool,
534534
) -> Result<Cow<'s, [W::SubjectChar]>, Error>

0 commit comments

Comments
 (0)