Skip to content

Commit 1ec5db6

Browse files
authored
feat: play sound on player death (#1046)
Added a glug sound when player dies to give additional audio feedback. Here is the audio used: https://freesound.org/people/brittmosel/sounds/529300/ This resolves #986.
1 parent 5d92c7d commit 1ec5db6

File tree

7 files changed

+14
-0
lines changed

7 files changed

+14
-0
lines changed

assets/player/skins/fishy/fishy.player.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ sounds:
99
grab_volume: 0.05
1010
drop: ../../sounds/drop.ogg
1111
drop_volume: 0.05
12+
death: ../../sounds/death.ogg
13+
death_volume: 0.3
1214

1315
stats:
1416
air_speed: 360

assets/player/skins/orcy/orcy.player.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ sounds:
99
grab_volume: 0.05
1010
drop: ../../sounds/drop.ogg
1111
drop_volume: 0.05
12+
death: ../../sounds/death.ogg
13+
death_volume: 0.3
1214

1315
stats:
1416
air_speed: 360

assets/player/skins/pescy/pescy.player.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ sounds:
99
grab_volume: 0.05
1010
drop: ../../sounds/drop.ogg
1111
drop_volume: 0.05
12+
death: ../../sounds/death.ogg
13+
death_volume: 0.3
1214

1315
stats:
1416
air_speed: 360

assets/player/skins/sharky/sharky.player.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ sounds:
99
grab_volume: 0.05
1010
drop: ../../sounds/drop.ogg
1111
drop_volume: 0.05
12+
death: ../../sounds/death.ogg
13+
death_volume: 0.3
1214

1315
stats:
1416
air_speed: 360

assets/player/sounds/death.ogg

21.1 KB
Binary file not shown.

src/core/metadata/player.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,9 @@ pub struct PlayerSoundsMeta {
9393

9494
pub drop_volume: f64,
9595
pub drop: Handle<AudioSource>,
96+
97+
pub death_volume: f64,
98+
pub death: Handle<AudioSource>,
9699
}
97100

98101
fn deserialize_arc<'de, T: Deserialize<'de>, D: Deserializer<'de>>(

src/core/player/state/states/dead.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ pub fn handle_player_state(
3232
mut animations: CompMut<AnimationBankSprite>,
3333
game_meta: Root<GameMeta>,
3434
mut collision_world: CollisionWorld,
35+
mut audio_center: ResMut<AudioCenter>,
3536
) {
3637
for (player_ent, (state, animation, _killed_player, player_idx)) in entities.iter_with((
3738
&player_states,
@@ -79,6 +80,8 @@ pub fn handle_player_state(
7980
let player_meta = &*assets.get(player_meta_handle);
8081
ragdoll::use_ragdoll_collider(player_ent, player_meta, &mut collision_world);
8182

83+
audio_center.play_sound(player_meta.sounds.death, player_meta.sounds.death_volume);
84+
8285
// animation.current = match killed_player.hit_from {
8386
// Some(hit_from)
8487
// if {

0 commit comments

Comments
 (0)