Skip to content

Commit 25c6e5a

Browse files
authored
RTC-520 Add PeerAdded and PeerDeleted notifications (#37)
* Add PeerAdded and PeerDeleted notifications * Update protos
1 parent 131186b commit 25c6e5a

File tree

4 files changed

+36
-1
lines changed

4 files changed

+36
-1
lines changed

jellyfish/events/__init__.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,10 @@
77
ServerMessageComponentCrashed,
88
ServerMessageHlsPlayable,
99
ServerMessageMetricsReport,
10+
ServerMessagePeerAdded,
1011
ServerMessagePeerConnected,
1112
ServerMessagePeerCrashed,
13+
ServerMessagePeerDeleted,
1214
ServerMessagePeerDisconnected,
1315
ServerMessageRoomCrashed,
1416
ServerMessageRoomCreated,
@@ -24,7 +26,9 @@
2426
"ServerMessageRoomCreated",
2527
"ServerMessageRoomDeleted",
2628
"ServerMessageRoomCrashed",
29+
"ServerMessagePeerAdded",
2730
"ServerMessagePeerConnected",
31+
"ServerMessagePeerDeleted",
2832
"ServerMessagePeerDisconnected",
2933
"ServerMessagePeerCrashed",
3034
"ServerMessageComponentCrashed",

jellyfish/events/_protos/jellyfish/__init__.py

Lines changed: 23 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protos

tests/test_notifier.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
from jellyfish import ComponentOptionsFile, Notifier, PeerOptionsWebRTC, RoomApi
1313
from jellyfish.events import (
1414
ServerMessageMetricsReport,
15+
ServerMessagePeerAdded,
1516
ServerMessagePeerConnected,
17+
ServerMessagePeerDeleted,
1618
ServerMessagePeerDisconnected,
1719
ServerMessageRoomCreated,
1820
ServerMessageRoomDeleted,
@@ -121,8 +123,10 @@ async def test_peer_connected_disconnected(
121123
):
122124
event_checks = [
123125
ServerMessageRoomCreated,
126+
ServerMessagePeerAdded,
124127
ServerMessagePeerConnected,
125128
ServerMessagePeerDisconnected,
129+
ServerMessagePeerDeleted,
126130
ServerMessageRoomDeleted,
127131
]
128132
assert_task = asyncio.create_task(assert_events(notifier, event_checks.copy()))
@@ -156,8 +160,10 @@ async def test_peer_connected_disconnected_deleted(
156160
):
157161
event_checks = [
158162
ServerMessageRoomCreated,
163+
ServerMessagePeerAdded,
159164
ServerMessagePeerConnected,
160165
ServerMessagePeerDisconnected,
166+
ServerMessagePeerDeleted,
161167
ServerMessageRoomDeleted,
162168
]
163169

@@ -194,7 +200,9 @@ async def test_peer_connected_room_deleted(
194200
):
195201
event_checks = [
196202
ServerMessageRoomCreated,
203+
ServerMessagePeerAdded,
197204
ServerMessagePeerConnected,
205+
ServerMessagePeerDeleted,
198206
ServerMessageRoomDeleted,
199207
]
200208
assert_task = asyncio.create_task(assert_events(notifier, event_checks.copy()))

0 commit comments

Comments
 (0)