Skip to content

Commit 82057b1

Browse files
committed
Fix room manager
1 parent 6faa6ff commit 82057b1

File tree

4 files changed

+570
-480
lines changed

4 files changed

+570
-480
lines changed

examples/room_manager/room_service.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ class Resource:
2222
class PeerAccess:
2323
room: Resource
2424
peer: Resource
25-
peer_token: str
26-
websocket_url: str
25+
peerToken: str
26+
url: str
2727

2828

2929
class RoomService:
@@ -32,7 +32,7 @@ def __init__(self, args: Namespace, logger: Logger):
3232
fishjam_url=args.fishjam_url,
3333
management_token=args.management_token,
3434
)
35-
self.websocket_url = args.fishjam_url.replace("http", "ws")
35+
self.url = args.fishjam_url.replace("http", "ws")
3636
self.room_name_to_room_id: dict[str, str] = {}
3737
self.peer_name_to_access: dict[str, PeerAccess] = {}
3838
self.logger = logger
@@ -95,8 +95,8 @@ def __create_peer(self, room_name: str, peer_name: str) -> PeerAccess:
9595
peer_access = PeerAccess(
9696
room=Resource(id=room_id, name=room_name),
9797
peer=Resource(id=peer.id, name=peer_name),
98-
peer_token=token,
99-
websocket_url=self.websocket_url,
98+
peerToken=token,
99+
url=self.url,
100100
)
101101

102102
self.peer_name_to_access[peer_name] = peer_access

fishjam/api/_fishjam_client.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,6 @@ class RoomOptions:
5858
Duration (in seconds) after which the room will be removed
5959
if no peers are connected. If not provided, this feature is disabled.
6060
"""
61-
room_id: str | None = None
62-
"""
63-
Custom id used for identifying room within Fishjam.
64-
Must be unique across all rooms. If not provided, random UUID is generated.
65-
"""
6661
video_codec: Literal["h264", "vp8"] | None = None
6762
"""Enforces video codec for each peer in the room"""
6863
webhook_url: str | None = None
@@ -130,7 +125,6 @@ def create_room(self, options: RoomOptions | None = None) -> Room:
130125
max_peers=options.max_peers,
131126
peer_disconnected_timeout=options.peer_disconnected_timeout,
132127
peerless_purge_timeout=options.peerless_purge_timeout,
133-
room_id=options.room_id,
134128
video_codec=codec,
135129
webhook_url=options.webhook_url,
136130
)

0 commit comments

Comments
 (0)