apply comment suggestions, refine frontend

Author: Gawor270

examples/selective_subscription/README.md

@@ -10,21 +10,22 @@ Demo application showing selective subscription functionality with [Fishjam](htt
 
 ## Quick Start
 
-1. Install dependencies(in project root):
+1. Install dependencies (in the `examples/selective_subscription` directory):
    ```bash
+   cd examples/selective_subscription
    uv sync
    ```
 
 2. Run the server:
    ```bash
    FISHJAM_ID=<your-id> \
    FISHJAM_MANAGEMENT_TOKEN=<your-token> \
-   uv run examples/selective_subscription/main.py
+   uv run main.py
    ```
 
 3. Open http://localhost:8000 in your browser
 
-## Usage
+You create peers using the web UI at [http://localhost:8000](http://localhost:8000).
 
 1. Create peers with names
 2. Copy peer tokens and use them with a WebRTC client (e.g., [minimal-react](https://github.com/fishjam-cloud/web-client-sdk/tree/main/examples/react-client/minimal-react))

examples/selective_subscription/pyproject copy.toml

@@ -7,10 +7,12 @@ requires-python = ">=3.11"
 dependencies = [
     "starlette>=0.35.0",
     "uvicorn>=0.25.0",
-    "jinja2>=3.1.0",
-    "python-multipart>=0.0.6",
+    "fishjam-server-sdk",
 ]
 
+[tool.uv.sources]
+fishjam-server-sdk = { workspace = true }
+
 [build-system]
 requires = ["hatchling"]
 build-backend = "hatchling.build"

examples/selective_subscription/pyproject.toml

@@ -2,6 +2,5 @@
 
 FISHJAM_ID = os.environ["FISHJAM_ID"]
 FISHJAM_TOKEN = os.environ["FISHJAM_MANAGEMENT_TOKEN"]
-FISHJAM_URL = os.getenv("FISHJAM_URL", "http://localhost:5002")
 HOST = os.getenv("HOST", "localhost")
 PORT = int(os.getenv("PORT", "8000"))

examples/selective_subscription/selective_subscription/config.py

@@ -8,20 +8,18 @@
 
 class RoomService:
     def __init__(self):
-        self.fishjam = FishjamClient(FISHJAM_ID, FISHJAM_TOKEN)
+        self.fishjam = FishjamClient(fishjam_id=FISHJAM_ID, management_token=FISHJAM_TOKEN)
         self.room = self.fishjam.create_room(
             RoomOptions(max_peers=10, room_type="conference")
         )
 
     def get_or_create_room(self) -> Room:
-        if self.room:
-            try:
-                room = self.fishjam.get_room(self.room.id)
-                return room
-            except NotFoundError:
-                pass
+        try:
+            self.room = self.fishjam.get_room(self.room.id)
+        except NotFoundError:
+            self.room = self.fishjam.create_room()
 
-        return self.fishjam.create_room()
+        return self.room
 
     def create_peer(self) -> tuple[Peer, str]:
         room = self.get_or_create_room()
@@ -36,16 +34,3 @@ def subscibe_peer(self, peer_id: str, target_peer_id: str):
     def subscribe_tracks(self, peer_id: str, track_ids: List[str]):
         room = self.get_or_create_room()
         self.fishjam.subscribe_tracks(room.id, peer_id, track_ids)
-
-    def get_peer_session(self, peer_id: str):
-        room = self.get_or_create_room()
-        for p in room.peers:
-            if p.id == peer_id:
-
-                class _Session:
-                    def __init__(self):
-                        self.subscribed_peers: set[str] = set()
-
-                return _Session()
-
-        return None