Skip to content

Commit da5856d

Browse files
Update old tests
1 parent 5fff5fc commit da5856d

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

tests/test_notifier.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
import pytest
1010
import requests
11+
import websockets
1112

1213
from fishjam import FishjamClient, FishjamNotifier, RoomOptions
1314
from fishjam.events import (
@@ -68,8 +69,9 @@ def handle_notitifcation(_notification):
6869

6970
notifier_task = asyncio.create_task(notifier.connect())
7071
await notifier.wait_ready()
71-
# pylint: disable=protected-access
72-
assert notifier._websocket.open
72+
assert (
73+
notifier._websocket and notifier._websocket.state == websockets.State.OPEN
74+
)
7375

7476
await cancel(notifier_task)
7577

tests/test_room_api.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def room_api():
5858

5959

6060
class TestCreateRoom:
61-
def test_no_params(self, room_api):
61+
def test_no_params(self, room_api: FishjamClient):
6262
room = room_api.create_room()
6363

6464
config = RoomConfig(
@@ -71,6 +71,7 @@ def test_no_params(self, room_api):
7171
config.__setitem__(
7272
"peerlessPurgeTimeout", room.config.__getitem__("peerlessPurgeTimeout")
7373
)
74+
config.__setitem__("geoLoc", room.config.__getitem__("geoLoc"))
7475

7576
assert room == Room(
7677
config=config,
@@ -98,6 +99,7 @@ def test_valid_params(self, room_api):
9899
config.__setitem__(
99100
"peerlessPurgeTimeout", room.config.__getitem__("peerlessPurgeTimeout")
100101
)
102+
config.__setitem__("geoLoc", room.config.__getitem__("geoLoc"))
101103

102104
assert room == Room(
103105
config=config,
@@ -158,6 +160,7 @@ def test_valid(self, room_api: FishjamClient):
158160
config.__setitem__(
159161
"peerlessPurgeTimeout", room.config.__getitem__("peerlessPurgeTimeout")
160162
)
163+
config.__setitem__("geoLoc", room.config.__getitem__("geoLoc"))
161164

162165
assert Room(
163166
peers=[],

0 commit comments

Comments
 (0)