Extract numeric (sindresorhus#1237)

Author: fisker

rules/number-literal-case.js

@@ -1,5 +1,6 @@
 'use strict';
 const getDocumentationUrl = require('./utils/get-documentation-url');
+const {isNumber, isBigInt} = require('./utils/numeric');
 
 const MESSAGE_ID = 'number-literal-case';
 const messages = {
@@ -18,12 +19,12 @@ const fix = raw => {
 const create = context => {
 	return {
 		Literal: node => {
-			const {value, raw, bigint} = node;
+			const {raw} = node;
 
 			let fixed = raw;
-			if (typeof value === 'number') {
+			if (isNumber(node)) {
 				fixed = fix(raw);
-			} else if (bigint) {
+			} else if (isBigInt(node)) {
 				fixed = fix(raw.slice(0, -1)) + 'n';
 			}
 

rules/numeric-separators-style.js

@@ -1,5 +1,6 @@
 'use strict';
 const getDocumentationUrl = require('./utils/get-documentation-url');
+const numeric = require('./utils/numeric');
 
 const MESSAGE_ID = 'numeric-separators-style';
 const messages = {
@@ -34,16 +35,8 @@ function addSeparatorFromLeft(value, options) {
 }
 
 function formatNumber(value, options) {
-	const parts = value.split('.');
-	const [integer, fractional] = parts;
-
-	let formatted = addSeparator(integer, options);
-	if (parts.length === 2) {
-		formatted += '.';
-		formatted += addSeparatorFromLeft(fractional, options);
-	}
-
-	return formatted;
+	const {integer, dot, fractional} = numeric.parseFloat(value);
+	return addSeparator(integer, options) + dot + addSeparatorFromLeft(fractional, options);
 }
 
 function format(value, {prefix, data}, options) {
@@ -55,10 +48,10 @@ function format(value, {prefix, data}, options) {
 
 	const {
 		number,
-		mark = '',
-		sign = '',
-		power = ''
-	} = value.match(/^(?<number>.*?)(?:(?<mark>e)(?<sign>[+-])?(?<power>\d+))?$/i).groups;
+		mark,
+		sign,
+		power
+	} = numeric.parseNumber(value);
 
 	return formatNumber(number, formatOption) + mark + sign + addSeparator(power, options['']);
 }
@@ -106,23 +99,20 @@ const create = context => {
 
 	return {
 		Literal: node => {
-			const {value, bigint, raw} = node;
+			if (!numeric.isNumberic(node) || numeric.isLegacyOctal(node)) {
+				return;
+			}
+
+			const {raw} = node;
 			let number = raw;
 			let suffix = '';
-			if (typeof value === 'number') {
-				// Legacy octal
-				if (/^0\d+$/.test(raw)) {
-					return;
-				}
-			} else if (bigint) {
+			if (numeric.isBigInt(node)) {
 				number = raw.slice(0, -1);
 				suffix = 'n';
-			} else {
-				return;
 			}
 
 			const strippedNumber = number.replace(/_/g, '');
-			const {prefix = '', data} = strippedNumber.match(/^(?<prefix>0[box])?(?<data>.*)$/i).groups;
+			const {prefix, data} = numeric.getPrefix(strippedNumber);
 
 			const {onlyIfContainsSeparator} = options[prefix.toLowerCase()];
 			if (onlyIfContainsSeparator && !raw.includes('_')) {

rules/utils/numeric.js

@@ -0,0 +1,44 @@
+'use strict';
+
+// Determine whether this node is a decimal integer literal.
+// Copied from https://github.com/eslint/eslint/blob/cc4871369645c3409dc56ded7a555af8a9f63d51/lib/rules/utils/ast-utils.js#L1237
+const DECIMAL_INTEGER_PATTERN = /^(?:0|0[0-7]*[89]\d*|[1-9](?:_?\d)*)$/u;
+const isDecimalInteger = node => isNumber(node) && DECIMAL_INTEGER_PATTERN.test(node.raw);
+
+const isNumber = node => typeof node.value === 'number';
+const isBigInt = node => Boolean(node.bigint);
+const isNumberic = node => isNumber(node) || isBigInt(node);
+const isLegacyOctal = node => isNumber(node) && /^0\d+$/.test(node.raw);
+
+function getPrefix(text) {
+	let prefix = '';
+	let data = text;
+
+	if (/^0[box]/i.test(text)) {
+		prefix = text.slice(0, 2);
+		data = text.slice(2);
+	}
+
+	return {prefix, data};
+}
+
+function parseNumber(text) {
+	const {
+		number,
+		mark = '',
+		sign = '',
+		power = ''
+	} = text.match(/^(?<number>.*?)(?:(?<mark>e)(?<sign>[+-])?(?<power>\d+))?$/i).groups;
+
+	return {number, mark, sign, power};
+}
+
+function parseFloat(text) {
+	const parts = text.split('.');
+	const [integer, fractional = ''] = parts;
+	const dot = parts.length === 2 ? '.' : '';
+
+	return {integer, dot, fractional};
+}
+
+module.exports = {isNumber, isBigInt, isNumberic, isLegacyOctal, getPrefix, parseNumber, parseFloat, isDecimalInteger};

rules/utils/should-add-parentheses-to-member-expression-object.js

@@ -1,14 +1,7 @@
 'use strict';
 
 const isNewExpressionWithParentheses = require('./is-new-expression-with-parentheses');
-
-// Determine whether this node is a decimal integer literal.
-// Copied from https://github.com/eslint/eslint/blob/cc4871369645c3409dc56ded7a555af8a9f63d51/lib/rules/utils/ast-utils.js#L1237
-const DECIMAL_INTEGER_PATTERN = /^(?:0|0[0-7]*[89]\d*|[1-9](?:_?\d)*)$/u;
-const isDecimalInteger = node =>
-	node.type === 'Literal' &&
-	typeof node.value === 'number' &&
-	DECIMAL_INTEGER_PATTERN.test(node.raw);
+const {isDecimalInteger} = require('./numeric');
 
 /**
 Check if parentheses should to be added to a `node` when it's used as an `object` of `MemberExpression`.