feat: change nnc to string

Author: hugomrdias

packages/homestar/package.json

@@ -74,7 +74,7 @@
     "esbuild": "^0.20.1",
     "esbuild-plugin-replace-regex": "^0.0.2",
     "get-tsconfig": "^4.7.3",
-    "iso-base": "^2.0.1",
+    "iso-base": "^3.0.0",
     "just-kebab-case": "^4.2.0",
     "multiformats": "^13.1.0",
     "object-path": "^0.11.8",
@@ -83,7 +83,7 @@
   "devDependencies": {
     "@types/get-value": "^3.0.5",
     "@types/json-templates": "^3.0.3",
-    "@types/node": "^20.11.25",
+    "@types/node": "^20.11.26",
     "@types/object-path": "^0.11.4",
     "execa": "^8.0.1",
     "homestar-runtime": "rc",
@@ -92,7 +92,7 @@
     "playwright-test": "^14.1.1",
     "tempy": "^3.1.0",
     "testcontainers": "^10.7.2",
-    "type-fest": "^4.11.1",
+    "type-fest": "^4.12.0",
     "unws": "^0.2.4",
     "ws": "^8.16.0"
   },

packages/homestar/src/schemas.js

@@ -62,10 +62,10 @@ export const Receipt = z.object({
 export const Task = z.object({
   op: z.string(),
   rsc: z.string().url(),
-  nnc: z.union([
-    z.string().length(0),
-    z.object({ '/': z.object({ bytes: z.string() }) }),
-  ]),
+  /**
+   * Base 32 hex (lower) encoded random bytes, either 12 or 16 bytes long
+   */
+  nnc: z.string(),
   input: z.object({
     func: z.string(),
     args: z.array(z.any()),

packages/homestar/src/workflow/index.js

@@ -280,7 +280,7 @@ export function invocation(opts) {
         args: opts.args,
         func: opts.func,
       },
-      nnc: '',
+      nnc: opts.nnc ?? '',
       op: 'wasm/run',
       rsc: opts.resource,
     },

packages/homestar/src/workflow/types.ts

@@ -53,6 +53,10 @@ export interface InvocationOptions<Args extends any[] = any[]> {
   args: Args
   func: string
   resource: Resource
+  /**
+   * Base 32 hex (lower) encoded random bytes, either 12 or 16 bytes long
+   */
+  nnc?: string
 }
 
 export interface TemplateOptions<

packages/homestar/test/wasmify.node.test.js

@@ -2,8 +2,9 @@ import * as url from 'url'
 import path from 'path'
 import { assert, suite } from 'playwright-test/taps'
 import pDefer from 'p-defer'
-import { base64 } from 'iso-base/rfc4648'
+import { base32hex, base64 } from 'iso-base/rfc4648'
 import { utf8 } from 'iso-base/utf8'
+import { randomBytes } from 'iso-base/crypto'
 import { temporaryDirectory } from 'tempy'
 import { WebsocketTransport } from '@fission-codes/channel/transports/ws.js'
 import { build } from '../src/wasmify/index.js'
@@ -152,3 +153,63 @@ test(
     timeout: 120_000,
   }
 )
+
+test(
+  'should wasmify with multiple tasks and nonce',
+  async function () {
+    const { outPath } = await build({
+      entryPoint: path.join(__dirname, 'fixtures', 'wasmify', 'hello.ts'),
+      outDir,
+    })
+
+    /** @type {import('p-defer').DeferredPromise<string>} */
+    const prom = pDefer()
+
+    const args = ['hello', 1]
+
+    const wasmCID = await addFSFileToIPFS(outPath)
+    const workflow1 = await workflow({
+      name: 'sum',
+      workflow: {
+        tasks: [
+          invocation({
+            name: 'sum1',
+            func: 'sum',
+            args,
+            resource: `ipfs://${wasmCID}`,
+            nnc: base32hex.encode(randomBytes(12), false),
+          }),
+          invocation({
+            name: 'sum2',
+            func: 'sum',
+            args: ['{{needs.sum1.output}}', 2],
+            resource: `ipfs://${wasmCID}`,
+            nnc: base32hex.encode(randomBytes(12), false),
+          }),
+        ],
+      },
+    })
+
+    /**
+     * @type {number}
+     */
+    let count = 0
+    const { error } = await hs.runWorkflow(workflow1, (data) => {
+      count++
+
+      if (count === 2) {
+        prom.resolve(data.receipt.out[1])
+      }
+    })
+
+    if (error) {
+      return assert.fail(error)
+    }
+
+    const r = await prom.promise
+    assert.equal(r, 'hello12')
+  },
+  {
+    timeout: 30_000,
+  }
+)