Check and fix valgrind errors (telefonicaid#4709)

* FIX phony modification to trigger valgrind check

* FIX leaks

* FIX leaks

Author: fgalan

src/lib/apiTypesV2/GeoFilter.cpp

@@ -53,6 +53,17 @@ GeoFilter::GeoFilter()
 
 
 
+/* ****************************************************************************
+*
+* GeoFilter::~GeoFilter -
+*/
+GeoFilter::~GeoFilter()
+{
+  release();
+}
+
+
+
 /* ****************************************************************************
 *
 * pointVectorRelease - 

src/lib/apiTypesV2/GeoFilter.h

@@ -47,6 +47,7 @@ typedef struct GeoFilter
   orion::Georel       georel;
 
   GeoFilter();
+  ~GeoFilter();
 
   int          fill(const std::string&  geometry,
                     const std::string&  coords,

src/lib/mongoBackend/mongoCreateSubscription.cpp

@@ -65,19 +65,20 @@ static void insertInCache
   double               now
 )
 {
-  // set strinFilterP and mdStringFilterP (they will be used later in subCacheItemInsert)
+  // set stringFilterP and mdStringFilterP (they will be used later in subCacheItemInsert)
   std::string err;
 
   StringFilter* stringFilterP = sub.subject.condition.expression.stringFilter.clone(&err);
   if (stringFilterP == NULL)
   {
-    LM_E(("Runtime Error (cloning stringFilter: %s", err.c_str()));
+    LM_E(("Runtime Error (cloning stringFilter: %s)", err.c_str()));
     return;
   }
   StringFilter* mdStringFilterP = sub.subject.condition.expression.mdStringFilter.clone(&err);
-  if (stringFilterP == NULL)
+  if (mdStringFilterP == NULL)
   {
-    LM_E(("Runtime Error (cloning mdStringFilterP: %s", err.c_str()));
+    delete stringFilterP;
+    LM_E(("Runtime Error (cloning mdStringFilterP: %s)", err.c_str()));
     return;
   }
 
@@ -118,6 +119,11 @@ static void insertInCache
                      sub.subject.condition.notifyOnMetadataChange);
 
   cacheSemGive(__FUNCTION__, "Inserting subscription in cache");
+
+  // Release dynamic memory allocated by clone() methods
+  // (note stringFilterP and mdStringFilterP can be not NULL as that condition is already checked above)
+  delete stringFilterP;
+  delete mdStringFilterP;
 }
 
 

src/lib/mongoBackend/mongoUpdateSubscription.cpp

@@ -151,14 +151,15 @@ static void updateInCache
   StringFilter* stringFilterP = subUp.subject.condition.expression.stringFilter.clone(&err);
   if (stringFilterP == NULL)
   {
-    LM_E(("Runtime Error (cloning stringFilter: %s", err.c_str()));
+    LM_E(("Runtime Error (cloning stringFilter: %s)", err.c_str()));
     return;
   }
 
   StringFilter* mdStringFilterP = subUp.subject.condition.expression.mdStringFilter.clone(&err);
-  if (stringFilterP == NULL)
+  if (mdStringFilterP == NULL)
   {
-    LM_E(("Runtime Error (cloning mdStringFilterP: %s", err.c_str()));
+    delete stringFilterP;
+    LM_E(("Runtime Error (cloning mdStringFilterP: %s)", err.c_str()));
     return;
   }
 
@@ -306,6 +307,11 @@ static void updateInCache
   }
 
   cacheSemGive(__FUNCTION__, "Updating cached subscription");
+
+  // Release dynamic memory allocated by clone() methods
+  // (note stringFilterP and mdStringFilterP can be not NULL as that condition is already checked above)
+  delete stringFilterP;
+  delete mdStringFilterP;
 }