Commit f09764e
committed
Mark a handful of functions on the calling-into-Wasm path as
This provides an improvement across the board for our `sync/no-hook` benchmarks:
<details>
<summary>Benchmark Results</summary>
```
$ cargo bench --profile profiling --bench call '\bsync/no-hook' -- --baseline main
Finished `profiling` profile [optimized + debuginfo] target(s) in 0.28s
Running benches/call.rs (target/profiling/deps/call-b0a2bedd3336ad76)
sync/no-hook/core - host-to-wasm - typed - nop
time: [27.334 ns 27.499 ns 27.668 ns]
change: [-16.388% -14.870% -13.479%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe
sync/no-hook/core - host-to-wasm - untyped - nop
time: [44.141 ns 44.429 ns 44.757 ns]
change: [-18.380% -17.041% -15.670%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe
sync/no-hook/core - host-to-wasm - unchecked - nop
time: [29.731 ns 29.983 ns 30.262 ns]
change: [-25.104% -22.176% -19.159%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe
sync/no-hook/core - host-to-wasm - typed - nop-params-and-results
time: [28.990 ns 29.143 ns 29.303 ns]
change: [-25.804% -24.562% -23.372%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe
sync/no-hook/core - host-to-wasm - untyped - nop-params-and-results
time: [110.00 ns 110.65 ns 111.46 ns]
change: [-11.967% -9.0070% -6.1347%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
2 (2.00%) high mild
5 (5.00%) high severe
sync/no-hook/core - host-to-wasm - unchecked - nop-params-and-results
time: [58.828 ns 59.089 ns 59.418 ns]
change: [-15.596% -13.573% -11.484%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severe
sync/no-hook/core - wasm-to-host - typed - nop
time: [6.6209 ns 6.6615 ns 6.7077 ns]
change: [-53.555% -52.878% -52.116%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
5 (5.00%) high mild
1 (1.00%) high severe
sync/no-hook/core - wasm-to-host - typed - nop-params-and-results
time: [7.9783 ns 8.0173 ns 8.0611 ns]
change: [-54.341% -53.947% -53.505%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severe
sync/no-hook/core - wasm-to-host - untyped - nop
time: [18.306 ns 18.393 ns 18.491 ns]
change: [-29.104% -28.127% -27.171%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe
sync/no-hook/core - wasm-to-host - untyped - nop-params-and-results
time: [67.741 ns 68.120 ns 68.601 ns]
change: [-26.453% -25.061% -23.663%] (p = 0.00 < 0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
6 (6.00%) high mild
6 (6.00%) high severe
sync/no-hook/core - wasm-to-host - unchecked - nop
time: [6.8379 ns 6.8915 ns 6.9566 ns]
change: [-55.623% -55.062% -54.481%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe
sync/no-hook/core - wasm-to-host - unchecked - nop-params-and-results
time: [27.856 ns 28.024 ns 28.214 ns]
change: [-17.320% -16.103% -15.038%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
6 (6.00%) high mild
4 (4.00%) high severe
sync/no-hook/component - host-to-wasm - typed - nop
time: [55.126 ns 55.506 ns 55.932 ns]
change: [-19.458% -18.098% -16.736%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe
sync/no-hook/component - host-to-wasm - untyped - nop
time: [101.42 ns 102.06 ns 102.82 ns]
change: [-15.679% -14.108% -12.523%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
7 (7.00%) high mild
2 (2.00%) high severe
sync/no-hook/component - host-to-wasm - typed - nop-params-and-results
time: [61.482 ns 62.017 ns 62.591 ns]
change: [-16.576% -15.100% -13.595%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
9 (9.00%) high mild
1 (1.00%) high severe
sync/no-hook/component - host-to-wasm - untyped - nop-params-and-results
time: [223.50 ns 224.72 ns 226.05 ns]
change: [-21.732% -20.178% -18.679%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe
sync/no-hook/component - wasm-to-host - typed - nop
time: [39.115 ns 39.295 ns 39.500 ns]
change: [-15.139% -13.886% -12.721%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
1 (1.00%) low mild
2 (2.00%) high mild
5 (5.00%) high severe
sync/no-hook/component - wasm-to-host - typed - nop-params-and-results
time: [47.234 ns 47.458 ns 47.745 ns]
change: [-13.833% -11.951% -9.8784%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
3 (3.00%) high mild
6 (6.00%) high severe
sync/no-hook/component - wasm-to-host - untyped - nop
time: [52.311 ns 52.556 ns 52.817 ns]
change: [-12.736% -11.712% -10.693%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
4 (4.00%) high mild
5 (5.00%) high severe
sync/no-hook/component - wasm-to-host - untyped - nop-params-and-results
time: [239.71 ns 241.59 ns 244.11 ns]
change: [-29.804% -28.173% -26.415%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
4 (4.00%) high mild
5 (5.00%) high severe
```
</details>#[inline]
1 parent 20544ac commit f09764e
File tree
6 files changed
+12
-0
lines changed- crates/wasmtime/src/runtime
- func
- vm
6 files changed
+12
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
943 | 943 | | |
944 | 944 | | |
945 | 945 | | |
| 946 | + | |
946 | 947 | | |
947 | 948 | | |
948 | 949 | | |
| |||
1178 | 1179 | | |
1179 | 1180 | | |
1180 | 1181 | | |
| 1182 | + | |
1181 | 1183 | | |
1182 | 1184 | | |
1183 | 1185 | | |
| |||
1234 | 1236 | | |
1235 | 1237 | | |
1236 | 1238 | | |
| 1239 | + | |
1237 | 1240 | | |
1238 | 1241 | | |
1239 | 1242 | | |
| |||
1737 | 1740 | | |
1738 | 1741 | | |
1739 | 1742 | | |
| 1743 | + | |
1740 | 1744 | | |
1741 | 1745 | | |
1742 | 1746 | | |
| |||
1751 | 1755 | | |
1752 | 1756 | | |
1753 | 1757 | | |
| 1758 | + | |
1754 | 1759 | | |
1755 | 1760 | | |
1756 | 1761 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| 96 | + | |
96 | 97 | | |
97 | 98 | | |
98 | 99 | | |
| |||
179 | 180 | | |
180 | 181 | | |
181 | 182 | | |
| 183 | + | |
182 | 184 | | |
183 | 185 | | |
184 | 186 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2384 | 2384 | | |
2385 | 2385 | | |
2386 | 2386 | | |
| 2387 | + | |
2387 | 2388 | | |
2388 | 2389 | | |
2389 | 2390 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| 85 | + | |
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
833 | 833 | | |
834 | 834 | | |
835 | 835 | | |
| 836 | + | |
836 | 837 | | |
837 | 838 | | |
838 | 839 | | |
| |||
867 | 868 | | |
868 | 869 | | |
869 | 870 | | |
| 871 | + | |
870 | 872 | | |
871 | 873 | | |
872 | 874 | | |
| |||
0 commit comments