Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Commit 5025162

Browse files
fivetran-joemarkiewiczfivetran-data-model-botfivetran-catfritzgithub-actions[bot]fivetran-jamie
authored
feature/is-closed-support (#146)
* feature/is-closed-support * additional updates * Q2 FY26 Automatic Package Updates (#147) * Q2 FY26: Apply automated update. * Update README.md --------- Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> * Update CHANGELOG.md * Q2 FY26: Update auto-release workflow only. (#149) Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> * Generate dbt docs via GitHub Actions * Apply suggestions from code review Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com> * Update CHANGELOG.md * Generate dbt docs via GitHub Actions --------- Co-authored-by: Fivetran Maintainer Bot <129092423+fivetran-data-model-bot@users.noreply.github.com> Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
1 parent 1816621 commit 5025162

15 files changed

+254
-132
lines changed
Lines changed: 32 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,38 @@
1-
## PR Overview
2-
**This PR will address the following Issue/Feature:**
1+
<!--
2+
Pre-Submission Reminders
3+
Before marking this PR as "ready for review":
34
4-
**This PR will result in the following new package version:**
5-
<!--- Please add details around your decision for breaking vs non-breaking version upgrade. If this is a breaking change, were backwards-compatible options explored? -->
5+
- `dbt run --full-refresh && dbt test`
6+
- `dbt run` && `dbt test` (if incremental models are present)
7+
- The related issue is linked, tagged, and appropriately assigned
8+
- Documentation and version updates are included, if applicable
9+
- `docs` have been regenerated (unless there are no code or YAML changes)
10+
- BuildKite integration tests are passing
11+
-->
612

7-
**Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:**
8-
<!--- Copy/paste the CHANGELOG for this version below. -->
13+
## PR Overview
14+
**Package version introduced in this PR:**
15+
-
916

10-
## PR Checklist
11-
### Basic Validation
12-
Please acknowledge that you have successfully performed the following commands locally:
13-
- [ ] dbt run –full-refresh && dbt test
14-
- [ ] dbt run (if incremental models are present) && dbt test
17+
**This PR addresses the following Issue/Feature(s):**
18+
<!-- Add Issue # or internal ticket reference -->
19+
-
1520

16-
Before marking this PR as "ready for review" the following have been applied:
17-
- [ ] The appropriate issue has been linked, tagged, and properly assigned
18-
- [ ] All necessary documentation and version upgrades have been applied
19-
- [ ] docs were regenerated (unless this PR does not include any code or yml updates)
20-
- [ ] BuildKite integration tests are passing
21-
- [ ] Detailed validation steps have been provided below
21+
**Summary of changes:**
22+
<!-- 1-2 sentences describing PR changes. -->
23+
-
2224

23-
### Detailed Validation
24-
Please share any and all of your validation steps:
25-
<!--- Provide the steps you took to validate your changes below. -->
25+
### Submission Checklist
26+
- [ ] Alignment meeting with the reviewer (if needed)
27+
- [ ] Timeline and validation requirements discussed
28+
- [ ] Provide validation details:
29+
- [ ] **Validation Steps:** Check for unintentional effects (e.g., add/run consistency & integrity tests)
30+
- [ ] **Testing Instructions:** Confirm the change addresses the issue(s)
31+
- [ ] **Focus Areas:** Complex logic or queries that need extra attention
32+
- [ ] Merge any relevant open PRs into this PR
2633

27-
### If you had to summarize this PR in an emoji, which would it be?
28-
<!--- For a complete list of markdown compatible emojis check our this git repo (https://gist.github.com/rxaviers/7360908) -->
29-
:dancer:
34+
### Changelog
35+
<!-- Recommend drafting changelog notes, then refining via ChatGPT using:
36+
"Draft a changelog entry based on the following notes." -->
37+
- [ ] Draft changelog for PR
38+
- [ ] Final changelog for release review

.github/workflows/auto-release.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ on:
33
pull_request:
44
types:
55
- closed
6-
branches:
7-
- main
6+
- labeled
87

98
jobs:
10-
call-workflow-passing-data:
11-
if: github.event.pull_request.merged
9+
release:
10+
if: |
11+
(github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'main') ||
12+
github.event.label.name == 'pre-release'
1213
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main
13-
secrets: inherit
14+
secrets: inherit
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
name: 'generate dbt docs'
2+
on:
3+
pull_request:
4+
types:
5+
- labeled
6+
7+
jobs:
8+
generate-docs:
9+
if: github.event.label.name == 'docs:ready'
10+
uses: fivetran/dbt_package_automations/.github/workflows/generate-docs.yml@main
11+
secrets: inherit
12+
with:
13+
schema_var_name: hubspot_schema

.gitignore

Lines changed: 70 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,73 @@
1-
2-
target/
1+
# dbt
2+
**/package-lock.yml
3+
package-lock.yml
4+
.dbt/
35
dbt_modules/
6+
dbt_packages/
47
logs/
8+
profiles.yml
9+
target/
10+
*.log
11+
12+
# IDE files
13+
.idea/
14+
.vscode/
15+
*~
16+
*.swp
17+
*.swo
18+
19+
# Jupyter Notebook
20+
.ipynb_checkpoints
21+
22+
# OS generated files
23+
**/.DS_Store
524
.DS_Store
6-
dbt_packages/
7-
env/
25+
.Spotlight-V100
26+
.Trashes
27+
._*
28+
Thumbs.db
29+
ehthumbs.db
30+
31+
# Python
32+
*.egg
33+
*.egg-info/
34+
*.py[cod]
35+
*.so
36+
*$py.class
37+
.Python
38+
__pycache__/
39+
build/
40+
develop-eggs/
41+
dist/
42+
downloads/
43+
eggs/
44+
.env
45+
.installed.cfg
46+
lib/
47+
lib64/
48+
MANIFEST
49+
parts/
50+
sdist/
51+
var/
52+
wheels/
53+
54+
# Secrets and credentials
55+
.env.*
56+
.secrets
57+
credentials.json
58+
service-account.json
59+
60+
# Temporary files
61+
.cache/
62+
*.temp
63+
*.tmp
64+
65+
# Virtual environments
66+
.conda/
67+
.env
68+
.venv
69+
ENV/
70+
env/
71+
env.bak/
72+
venv/
73+
venv.bak/

CHANGELOG.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,28 @@
1+
# dbt_hubspot_source v0.21.0
2+
3+
[PR #146](https://github.com/fivetran/dbt_hubspot_source/pull/146) includes the
4+
following updates:
5+
6+
## Schema Changes
7+
**1 total change • 1 possible breaking change**
8+
| **Model** | **Change type** | **Old name** | **New name** | **Notes** |
9+
|-----------|----------------|--------------|--------------|---------|
10+
| [stg_hubspot__deal_pipeline_stage](https://fivetran.github.io/dbt_hubspot_source/#!/model/model.hubspot_source.stg_hubspot__deal_pipeline_stage) | Column Renamed | `is_closed_won` | `is_closed` | Column renamed to more accurately match the source data. The renamed `is_closed` column is generated via a coalesce between the previous `closed_won` source column and the newly added `is_closed` column. This renamed column represents whether a deal is closed, regardless of its label as “Closed Won” or “Closed Lost.” You can still use the `pipeline_stage_label` column to differentiate between "Closed Won" and "Closed Lost" stages. |
11+
12+
## Under the Hood
13+
- Documented the column updates and deprecations in the respective yml files.
14+
- Updated the `deal_pipeline_stage_data` seed to include the `is_closed` column.
15+
- Introduced the generate-docs github workflow for consistent docs generation.
16+
- Updated the maintainer pull request template.
17+
- Updated conditions in `.github/workflows/auto-release.yml`.
18+
- Added `.github/workflows/generate-docs.yml`.
19+
- Added `+docs: show: False` to `integration_tests/dbt_project.yml`.
20+
- Migrated `flags` (e.g., `send_anonymous_usage_stats`, `use_colors`) from `sample.profiles.yml` to `integration_tests/dbt_project.yml`.
21+
- Updated `maintainer_pull_request_template.md` with improved checklist.
22+
- Refreshed README tag block:
23+
- Left-aligned and positioned below the H1 title.
24+
- Updated `.gitignore` to exclude additional DBT, Python, and system artifacts.
25+
126
# dbt_hubspot_source v0.20.0
227

328
[PR #144](https://github.com/fivetran/dbt_hubspot_source/pull/144) includes the following updates:

README.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,12 @@
44
<a alt="License"
55
href="https://github.com/fivetran/dbt_hubspot_source/blob/main/LICENSE">
66
<img src="https://img.shields.io/badge/License-Apache%202.0-blue.svg" /></a>
7-
<img src="https://img.shields.io/badge/dbt_Core™_version->=1.3.0_,<2.0.0-orange.svg" /></a>
7+
<a alt="dbt-core">
8+
<img src="https://img.shields.io/badge/dbt_Core™_version->=1.3.0_,<2.0.0-orange.svg" /></a>
89
<a alt="Maintained?">
910
<img src="https://img.shields.io/badge/Maintained%3F-yes-green.svg" /></a>
1011
<a alt="PRs">
1112
<img src="https://img.shields.io/badge/Contributions-welcome-blueviolet" /></a>
12-
<a alt="Fivetran Quickstart Compatible"
13-
href="https://fivetran.com/docs/transformations/dbt/quickstart">
14-
<img src="https://img.shields.io/badge/Fivetran_Quickstart_Compatible%3F-yes-green.svg" /></a>
1513
</p>
1614

1715
## What does this dbt package do?
@@ -44,7 +42,7 @@ Include the following hubspot_source package version in your `packages.yml` file
4442
```yaml
4543
packages:
4644
- package: fivetran/hubspot_source
47-
version: [">=0.19.0", "<0.20.0"]
45+
version: [">=0.21.0", "<0.22.0"]
4846
```
4947
### Step 3: Define database and schema variables
5048
By default, this package runs using your destination and the `hubspot` schema. If this is not where your HubSpot data is (for example, if your HubSpot schema is named `hubspot_fivetran`), add the following configuration to your root `dbt_project.yml` file:
@@ -219,11 +217,11 @@ models:
219217
hubspot_source:
220218
+schema: my_new_schema_name # leave blank for just the target_schema
221219
```
222-
220+
223221
#### Change the source table references
224222
If an individual source table has a different name than the package expects, add the table name as it appears in your destination to the respective variable:
225223
> IMPORTANT: See this project's [`dbt_project.yml`](https://github.com/fivetran/dbt_hubspot_source/blob/main/dbt_project.yml) variable declarations to see the expected names.
226-
224+
227225
```yml
228226
vars:
229227
hubspot_<default_source_table_name>_identifier: your_table_name
@@ -245,7 +243,7 @@ packages:
245243
- package: dbt-labs/spark_utils
246244
version: [">=0.3.0", "<0.4.0"]
247245
```
248-
246+
249247
## How is this package maintained and can I contribute?
250248
### Package Maintenance
251249
The Fivetran team maintaining this package _only_ maintains the latest version of the package. We highly recommend that you stay consistent with the [latest version](https://hub.getdbt.com/fivetran/hubspot_source/latest/) of the package and refer to the [CHANGELOG](https://github.com/fivetran/dbt_hubspot_source/blob/main/CHANGELOG.md) and release notes for more information on changes across versions.

dbt_project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 'hubspot_source'
2-
version: '0.20.0'
2+
version: '0.21.0'
33
config-version: 2
44
require-dbt-version: [">=1.3.0", "<2.0.0"]
55
models:

docs/catalog.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

docs/manifest.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

integration_tests/dbt_project.yml

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,19 @@ models:
99
vars:
1010
hubspot_source:
1111
## Enable when generating docs
12-
# hubspot_service_enabled: true
13-
# hubspot_deal_enabled: true
14-
# hubspot_contact_enabled: true
15-
# hubspot_sales_enabled: true
16-
# hubspot_company_enabled: true
17-
# hubspot_marketing_enabled: true
18-
# hubspot_contact_merge_audit_enabled: true
19-
# hubspot_using_all_email_events: true
20-
# hubspot_merged_deal_enabled: true
21-
# hubspot_ticket_deal_enabled: true
22-
# hubspot_engagement_communication_enabled: true
23-
# hubspot_role_enabled: true
24-
# hubspot_team_enabled: true
12+
# hubspot_service_enabled: true # @docs-include
13+
# hubspot_deal_enabled: true # @docs-include
14+
# hubspot_contact_enabled: true # @docs-include
15+
# hubspot_sales_enabled: true # @docs-include
16+
# hubspot_company_enabled: true # @docs-include
17+
# hubspot_marketing_enabled: true # @docs-include
18+
# hubspot_contact_merge_audit_enabled: true # @docs-include
19+
# hubspot_using_all_email_events: true # @docs-include
20+
# hubspot_merged_deal_enabled: true # @docs-include
21+
# hubspot_ticket_deal_enabled: true # @docs-include
22+
# hubspot_engagement_communication_enabled: true # @docs-include
23+
# hubspot_role_enabled: true # @docs-include
24+
# hubspot_team_enabled: true # @docs-include
2525

2626
hubspot_schema: hubspot_source_integration_tests_34
2727
hubspot_company_property_history_identifier: "company_property_history_data"
@@ -87,6 +87,8 @@ vars:
8787
# alias: "funky_field"
8888

8989
seeds:
90+
+docs:
91+
show: False
9092
hubspot_source_integration_tests:
9193
+quote_columns: "{{ true if target.type == 'redshift' else false }}"
9294
owner_data:
@@ -254,3 +256,5 @@ dispatch:
254256

255257
flags:
256258
send_anonymous_usage_stats: False
259+
260+
use_colors: True

0 commit comments

Comments
 (0)