Skip to content

Commit f2f9f2a

Browse files
committed
fix: Set the server and TCK related environment variables with the commands that use them
1 parent aa56c5d commit f2f9f2a

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed

.github/workflows/run-tck.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@ env:
1010
TCK_VERSION: 0.3.0.alpha
1111
# Tells uv to not need a venv, and instead use system
1212
UV_SYSTEM_PYTHON: 1
13-
SUT_JSONRPC_URL: http://localhost:8080
14-
SUT_GRPC_URL: http://localhost:9555
15-
# Longer timeout is needed to receive the events for test_streaming_methods.py::test_tasks_resubscribe
16-
TCK_STREAMING_TIMEOUT: 4.0
1713

1814

1915
# Only run the latest job
@@ -68,8 +64,10 @@ jobs:
6864
working-directory: a2a-tck
6965
- name: Start the WildFly SUT
7066
run: |
71-
mvn wildfly:start -B -Dversion.sdk=${SDK_VERSION} -pl tck -Dstartup-timeout=120 -Dwildfly.serverArgs="--stability=preview"
67+
SUT_JSONRPC_URL=http://localhost:8080 SUT_GRPC_URL=http://localhost:9555 mvn wildfly:start -B -Dversion.sdk=${SDK_VERSION} -pl tck -Dstartup-timeout=120 -Dwildfly.serverArgs="--stability=preview"
7268
- name: Run TCK
69+
env:
70+
TCK_STREAMING_TIMEOUT: 4.0 # Longer timeout is needed when running the TCK to receive the events for test_streaming_methods.py::test_tasks_resubscribe
7371
run: |
7472
./run_tck.py --sut-url ${SUT_JSONRPC_URL} --category all --transports jsonrpc,grpc --compliance-report report.json
7573
working-directory: a2a-tck

README.md

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,21 +43,18 @@ To run the TCK, build the full project
4343
mvn clean install -DskipTests
4444
```
4545

46-
Set the following environment variables:
47-
48-
```
49-
export SUT_JSONRPC_URL=http://localhost:8080
50-
export SUT_GRPC_URL=localhost:9555
51-
```
52-
5346
You now have a server provisioned with the `.war` deployed in the `tck/target/wildfly` folder.
5447

5548
We can start the server using the following command:
5649

5750
```bash
58-
./tck/target/wildfly/bin/standalone.sh --stability=preview
51+
SUT_JSONRPC_URL=http://localhost:8080 SUT_GRPC_URL=http://localhost:9555 tck/target/wildfly/bin/standalone.sh --stability=preview
5952
```
53+
6054
`--stability=preview` is needed since the TCK server is provisioned with the gRPC subsystem, which is currently at the `preview` stability level.
6155

56+
The `SUT_JSONRPC_URL` and `SUT_GRPC_URL` are used by the TCK server's `AgentCardProducer` to specify the transports supported by the server agent.
57+
6258
Once the server is up and running, run the TCK with the instructions in [a2aproject/a2a-tck](https://github.com/a2aproject/a2a-tck). Make sure you check out the correct tag of `a2aproject/a2a-tck` for the protocol version we are targeting.
6359

60+
Be sure to set `TCK_STREAMING_TIMEOUT=4.0` when running the TCK to ensure the tests wait long enough to receive the events for streaming methods.

0 commit comments

Comments
 (0)