Ensure "*_test.json" are not loaded as rules (#805)

* Ensure "*_test.json" are not loaded as rules

* Skip loading tests in base processor unit tests as rules

* added changelog entry

---------

Co-authored-by: kmeinerz1 <kaithomas.meinerz@bwi.de>

Author: ppcad

CHANGELOG.md

@@ -7,6 +7,9 @@
 * add `replacer` processor to replace substrings in fields using a syntax similar to the `dissector`
 
 ### Improvements
+
+* ensured that "_test.json" files are not loaded as rules
+
 ### Bugfix
 
 - Fixed logging error in _revoke_callback() by adding error handling

logprep/util/rule_loader.py

@@ -197,7 +197,7 @@ def rule_definitions(self) -> List[Dict]:
             raise TypeError(f"Expected a string, got {type(self.source)}")
         if self.source.endswith(".yaml") or self.source.endswith(".yml"):
             rule_definitions = GetterFactory.from_string(self.source).get_yaml()
-        elif self.source.endswith(".json"):
+        elif self.source.endswith(".json") and not self.source.endswith("_test.json"):
             rule_definitions = GetterFactory.from_string(self.source).get_json()
         if not isinstance(rule_definitions, list):
             rule_definitions = [rule_definitions]

tests/testdata/unit/clusterer/rules/not_a_rule_test.json

@@ -0,0 +1,11 @@
+[
+    {
+        "filter": "message",
+        "clusterer": {
+            "source_fields": ["message"],
+            "pattern": "test (signature) test",
+            "repl": "<+>\\1</+>"
+        },
+        "description": "insert a description text"
+    }
+]

tests/unit/processor/base.py

@@ -24,6 +24,7 @@
     ProcessingCriticalError,
 )
 from logprep.processor.base.rule import Rule
+from logprep.util.defaults import RULE_FILE_EXTENSIONS
 from tests.unit.component.base import BaseComponentTestCase
 
 yaml = YAML(typ="safe", pure=True)
@@ -59,7 +60,9 @@ def set_rules(rules_dirs):
         rules = []
         for rules_dir in rules_dirs:
             rule_paths = [
-                p for p in Path(rules_dir).glob("**/*") if p.suffix in [".yml", ".json", "yaml"]
+                path
+                for path in Path(rules_dir).glob("**/*")
+                if path.suffix in RULE_FILE_EXTENSIONS and not path.name.endswith("_test.json")
             ]
             for rule_path in rule_paths:
                 loaded_rules = []