You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Create pull_request_template.md
* Generate documentation preview in CI
* Add review comments
* Use message-template to link to the rendered PR docs nicely
* Fix review finding
* Replace single-language with single-version to circumvent bug with wrong url in PR description
* Briefly summarize your changes in a few bullet points (can and should correspond to [CHANGELOG.md](https://github.com/fkie-cad/Logprep/blob/main/CHANGELOG.md))
4
+
* Relates to #XXX (insert issue number here), if there is a corresponding GH issue
5
+
6
+
## Assignee
7
+
-[ ] The changes adhere to the [contribution guidelines](https://github.com/fkie-cad/Logprep/blob/main/CONTRIBUTING.md)
8
+
-[ ] I have performed a self-review of my code
9
+
-[ ] My changes generate no new warnings (e.g. flake8/mypy/pytest/...) other than deprecations
10
+
11
+
### Documentation
12
+
-[ ][README.md](https://github.com/fkie-cad/Logprep/blob/main/README.md) is up-to-date
13
+
-[ ][CHANGELOG.md](https://github.com/fkie-cad/Logprep/blob/main/CHANGELOG.md) is up-to-date
14
+
-[ ][Documentation](https://github.com/fkie-cad/Logprep/tree/main/doc/source) (doc/source) is up-to-date
15
+
-[ ][Preview for docs](#readthedocs-preview) looks fine
16
+
-[ ][Notebooks](https://github.com/fkie-cad/Logprep/tree/main/doc/source/development/notebooks) are up-to-date and functional
17
+
-[ ][Examples](https://github.com/fkie-cad/Logprep/tree/main/examples) are up-to-date and functional (including compose & k8s)
18
+
19
+
### Code Quality
20
+
-[ ] Patch test coverage > 95% and does not decrease
21
+
-[ ] New code uses correct & specific type hints
22
+
23
+
### How did you verify that the changes work in practice?
24
+
25
+
* List of (preferably easy reproducible) tests including OS
26
+
27
+
## Reviewer
28
+
-[ ] The code is readable/maintainable and follows the [contribution guidelines](https://github.com/fkie-cad/Logprep/blob/main/CONTRIBUTING.md)
29
+
-[ ][Documentation](#documentation) is up-to-date
30
+
-[ ] Tests (unit & acceptance) are meaningful and not over-mocked
0 commit comments