Fix some test bugs

Author: aretor

tests/test_functional.py

@@ -48,10 +48,20 @@ def test_fft_conv_functional(
     kernel_size = to_ntuple(kernel_size, n=signal.ndim - 2)
     w0 = torch.randn(out_channels, in_channels // groups, *kernel_size,
                      requires_grad=True)
-    w1 = w0.detach().clone().requires_grad()
+    w1 = w0.detach().clone().requires_grad_()
+
+    b0 = torch.randn(out_channels, requires_grad=True) if bias else None
+    b1 = b0.detach().clone().requires_grad_() if bias else None
 
-    y0 = fft_conv(signal, w0, **kwargs)
-    y1 = torch_conv(signal, w1, **kwargs)
+    kwargs = dict(
+        padding=padding,
+        stride=stride,
+        dilation=dilation,
+        groups=groups,
+    )
+
+    y0 = fft_conv(signal, w0, bias=b0, **kwargs)
+    y1 = torch_conv(signal, w1, bias=b1, **kwargs)
 
     _assert_almost_equal(y0, y1)
 

tests/test_module.py

@@ -39,24 +39,27 @@ def test_fft_conv_module(
         kernel_size=kernel_size,
         padding=padding,
         stride=stride,
-        dilation=1,
+        dilation=dilation,
         groups=groups,
         bias=bias,
         ndim=ndim,
     )
     batch_size = 2  # TODO: Make this non-constant?
     dims = ndim * [input_size]
     signal = torch.randn(batch_size, in_channels, *dims)
+
+    weight = fft_conv_layer.weight
+    bias = fft_conv_layer.bias
+
     kwargs = dict(
-        bias=fft_conv_layer.bias,
         padding=padding,
         stride=stride,
         dilation=dilation,
         groups=groups,
     )
 
     y0 = fft_conv_layer(signal)
-    y1 = torch_conv(signal, fft_conv_layer._weight, **kwargs)
+    y1 = torch_conv(signal, weight, bias=bias, **kwargs)
 
     _assert_almost_equal(y0, y1)
 

tests/utils.py

@@ -4,7 +4,7 @@
 
 def _assert_almost_equal(x: Tensor, y: Tensor) -> bool:
     abs_error = torch.abs(x - y)
-    assert abs_error.mean().item() < 1e-5
+    assert abs_error.mean().item() < 5e-5
     assert abs_error.max().item() < 1e-4
     return True