fix: extract SQL dialect from endpoint url

Author: bercianor

cli/flamingock-cli/src/main/java/io/flamingock/cli/config/DatabaseConfig.java

@@ -18,6 +18,7 @@
 import io.flamingock.internal.common.sql.SqlDialect;
 
 import java.util.Map;
+import java.util.Optional;
 
 public class DatabaseConfig {
     private MongoDBConfig mongodb;
@@ -269,16 +270,34 @@ public void setPassword(String password) {
             this.password = password;
         }
 
-        public SqlDialect getSqlDialect() {
-            return sqlDialect;
+        public Optional<SqlDialect> getSqlDialect() {
+            return sqlDialect == null ? Optional.empty() :  Optional.of(sqlDialect);
         }
 
         public void setSqlDialect(String sqlDialect) {
             this.sqlDialect = SqlDialect.valueOf(sqlDialect.toUpperCase());
         }
 
+        public SqlDialect getEffectiveSqlDialect() {
+            if (this.sqlDialect != null) {
+                return this.sqlDialect;
+            }
+            String[] parts = this.endpoint.split(":", 3);
+            if (parts.length < 2 || parts[1].isEmpty()) {
+                throw new IllegalStateException("Cannot determine SQL dialect from endpoint: " + this.endpoint);
+            }
+            String dialect = parts[1].toLowerCase();
+            if ("firebirdsql".equals(dialect)) dialect = "firebird";
+            if ("informix-sqli".equals(dialect)) dialect = "informix";
+            try {
+                return SqlDialect.valueOf(dialect.toUpperCase());
+            } catch (IllegalArgumentException e) {
+                throw new IllegalArgumentException("Unsupported SQL Dialect: " + dialect, e);
+            }
+        }
+
         public String getDriverClassName() {
-            switch (sqlDialect) {
+            switch (this.getEffectiveSqlDialect()) {
                 case MYSQL:
                     return "com.mysql.cj.jdbc.Driver";
                 case MARIADB:
@@ -302,7 +321,7 @@ public String getDriverClassName() {
                 case DB2:
                     return "com.ibm.db2.jcc.DB2Driver";
                 default:
-                    throw new IllegalArgumentException("Unsupported SQL Dialect: " + sqlDialect);
+                    throw new IllegalArgumentException("Unsupported SQL Dialect: " + this.getEffectiveSqlDialect());
             }
         }
 

cli/flamingock-cli/src/main/java/io/flamingock/cli/factory/SqlDataSourceFactory.java

@@ -38,11 +38,7 @@ public static DataSource createSqlDataSource(DatabaseConfig.SqlConfig config) {
             throw new IllegalArgumentException("Database endpoint is required");
         }
 
-        if (config.getSqlDialect() == null) {
-            throw new IllegalArgumentException("Sql dialect is required");
-        }
-
-        if (!SqlDialect.SQLITE.equals(config.getSqlDialect())) {
+        if (!SqlDialect.SQLITE.equals(config.getEffectiveSqlDialect())) {
             if (config.getUsername() == null) {
                 throw new IllegalArgumentException("Database username is required");
             }
@@ -54,16 +50,10 @@ public static DataSource createSqlDataSource(DatabaseConfig.SqlConfig config) {
         try {
             DataSource sqlDatasource;
 
-            if (config.getSqlDialect().equals(SqlDialect.SQLITE)) {
+            if (config.getEffectiveSqlDialect().equals(SqlDialect.SQLITE)) {
                 SQLiteDataSource sqliteDatasource = new SQLiteDataSource();
                 sqliteDatasource.setUrl(config.getEndpoint());
 
-                try (Connection conn = sqliteDatasource.getConnection();
-                     Statement stmt = conn.createStatement()) {
-                    stmt.execute("PRAGMA journal_mode=WAL;");
-                    stmt.execute("PRAGMA busy_timeout=5000;");
-                }
-
                 sqlDatasource = sqliteDatasource;
             } else {
                 HikariConfig datasourceConfig = new HikariConfig();

cli/flamingock-cli/src/test/java/io/flamingock/cli/SimpleCLITest.java

@@ -93,6 +93,6 @@ void shouldCreateTestConfigs() {
 
         assertThat(sqlConfig).isNotNull();
         assertThat(sqlConfig.getAudit().getSql()).isNotNull();
-        assertThat(sqlConfig.getAudit().getSql().getSqlDialect()).isEqualTo(SQLSERVER);
+        assertThat(sqlConfig.getAudit().getSql().getEffectiveSqlDialect()).isEqualTo(SQLSERVER);
     }
 }