feat: update sql audit store test with mariadb

Author: davidfrigolet

community/flamingock-auditstore-sql/build.gradle.kts

@@ -7,10 +7,12 @@ dependencies {
     testImplementation("com.microsoft.sqlserver:mssql-jdbc:12.4.2.jre8")
     testImplementation("com.oracle.database.jdbc:ojdbc8:21.9.0.0")
     testImplementation("org.postgresql:postgresql:42.7.3")
+    testImplementation("org.mariadb.jdbc:mariadb-java-client:3.3.2")
     testImplementation("org.testcontainers:mysql:1.21.3")
     testImplementation("org.testcontainers:mssqlserver:1.21.3")
     testImplementation("org.testcontainers:oracle-xe:1.21.3")
     testImplementation("org.testcontainers:postgresql:1.21.3")
+    testImplementation("org.testcontainers:mariadb:1.21.3")
     testImplementation(project(":utils:test-util"))
     testImplementation("com.zaxxer:HikariCP:3.4.5")
     testImplementation("org.testcontainers:junit-jupiter:1.21.3")

community/flamingock-auditstore-sql/src/test/java/io/flamingock/community/sql/SqlAuditStoreTest.java

@@ -53,12 +53,13 @@ static Stream<Arguments> dialectProvider() {
                 Arguments.of(SqlDialect.MYSQL, "mysql"),
                 Arguments.of(SqlDialect.SQLSERVER, "sqlserver"),
                 Arguments.of(SqlDialect.ORACLE, "oracle"),
-                Arguments.of(SqlDialect.POSTGRESQL, "postgresql")
+                Arguments.of(SqlDialect.POSTGRESQL, "postgresql"),
+                Arguments.of(SqlDialect.MARIADB, "mariadb")
         );
     }
 
     private TestContext setupTest(SqlDialect sqlDialect, String dialectName) throws SQLException {
-        JdbcDatabaseContainer<?> container = createContainer(dialectName);
+        JdbcDatabaseContainer<?> container = SqlAuditTestHelper.createContainer(dialectName);
         container.start();
 
         HikariConfig config = new HikariConfig();
@@ -68,7 +69,7 @@ private TestContext setupTest(SqlDialect sqlDialect, String dialectName) throws
         config.setDriverClassName(container.getDriverClassName());
         DataSource dataSource = new HikariDataSource(config);
 
-        createTables(dataSource, sqlDialect);
+        SqlAuditTestHelper.createTables(dataSource, sqlDialect);
 
         return new TestContext(dataSource, container, sqlDialect);
     }
@@ -119,102 +120,20 @@ public String getDatabaseName() {
                         .withDatabaseName("testdb")
                         .withUsername("test")
                         .withPassword("test");
+            case "mariadb":
+                return new MariaDBContainer<>("mariadb:11.3.2")
+                        .withDatabaseName("testdb")
+                        .withUsername("testuser")
+                        .withPassword("testpass");
             default:
                 throw new IllegalArgumentException("Unsupported dialect: " + dialectName);
         }
     }
 
-    private void createTables(DataSource dataSource, SqlDialect dialect) throws SQLException {
-        try (Connection conn = dataSource.getConnection()) {
-            dropTablesIfExist(conn, dialect);
-
-            String createTestTable = getCreateTestTableSql(dialect);
-            conn.createStatement().execute(createTestTable);
-
-            String createLockTable = getCreateLockTableSql(dialect);
-            conn.createStatement().execute(createLockTable);
-        }
-    }
-
-    private void dropTablesIfExist(Connection conn, SqlDialect dialect) throws SQLException {
-        String[] tables = {"flamingockAuditLog", "test_table", "flamingockLock"};
-        for (String table : tables) {
-            try {
-                String dropSql = getDropTableSql(table, dialect);
-                conn.createStatement().execute(dropSql);
-            } catch (SQLException e) {
-                // Ignore if table doesn't exist
-            }
-        }
-    }
-
-    private String getDropTableSql(String tableName, SqlDialect dialect) {
-        if (dialect == SqlDialect.ORACLE) {
-            return "DROP TABLE " + tableName + " CASCADE CONSTRAINTS";
-        }
-        return "DROP TABLE IF EXISTS " + tableName;
-    }
-
-    private String getCreateTestTableSql(SqlDialect dialect) {
-        switch (dialect) {
-            case MYSQL:
-            case SQLSERVER:
-                return "CREATE TABLE test_table (" +
-                        "id VARCHAR(255) PRIMARY KEY, " +
-                        "name VARCHAR(255), " +
-                        "field1 VARCHAR(255), " +
-                        "field2 VARCHAR(255))";
-            case POSTGRESQL:
-                return "CREATE TABLE test_table (" +
-                        "id VARCHAR(255) PRIMARY KEY," +
-                        "name VARCHAR(255)," +
-                        "field1 VARCHAR(255)," +
-                        "field2 VARCHAR(255))";
-            case ORACLE:
-                return "CREATE TABLE test_table (" +
-                        "id VARCHAR2(255) PRIMARY KEY, " +
-                        "name VARCHAR2(255), " +
-                        "field1 VARCHAR2(255), " +
-                        "field2 VARCHAR2(255))";
-            default:
-                throw new UnsupportedOperationException("Dialect not supported: " + dialect);
-        }
-    }
-
-    private String getCreateLockTableSql(SqlDialect dialect) {
-        switch (dialect) {
-            case MYSQL:
-                return "CREATE TABLE flamingockLock (" +
-                        "`key` VARCHAR(255) PRIMARY KEY, " +
-                        "status VARCHAR(32), " +
-                        "owner VARCHAR(255), " +
-                        "expires_at TIMESTAMP)";
-            case POSTGRESQL:
-                return "CREATE TABLE flamingockLock (" +
-                        "\"key\" VARCHAR(255) PRIMARY KEY," +
-                        "status VARCHAR(32)," +
-                        "owner VARCHAR(255)," +
-                        "expires_at TIMESTAMP)";
-            case SQLSERVER:
-                return "CREATE TABLE flamingockLock (" +
-                        "[key] VARCHAR(255) PRIMARY KEY, " +
-                        "status VARCHAR(32), " +
-                        "owner VARCHAR(255), " +
-                        "expires_at DATETIME)";
-            case ORACLE:
-                return "CREATE TABLE flamingockLock (" +
-                        "\"key\" VARCHAR2(255) PRIMARY KEY, " +
-                        "status VARCHAR2(32), " +
-                        "owner VARCHAR2(255), " +
-                        "expires_at TIMESTAMP)";
-            default:
-                throw new UnsupportedOperationException("Dialect not supported: " + dialect);
-        }
-    }
-
     private Class<?>[] getChangeClasses(String dialectName, String scenario) {
         switch (dialectName) {
             case "mysql":
+            case "mariadb":
                 if ("happyPath".equals(scenario)) {
                     return new Class<?>[]{
                             io.flamingock.community.sql.changes.mysql.happyPath._001__create_index.class,
@@ -442,7 +361,7 @@ void failedWithRollback(SqlDialect sqlDialect, String dialectName) throws Except
                 }
 
                 // Verify index exists
-                verifyIndexExists(context);
+                SqlAuditTestHelper.verifyIndexExists(context);
 
                 // Verify partial data
                 try (Connection conn = context.dataSource.getConnection();
@@ -531,76 +450,14 @@ void failedWithoutRollback(SqlDialect sqlDialect, String dialectName) throws Exc
                 }
 
                 // Verify index exists and data state
-                verifyIndexExists(context);
+                SqlAuditTestHelper.verifyIndexExists(context);
                 verifyPartialDataState(context);
             }
         } finally {
             tearDown(context);
         }
     }
 
-    private void verifyIndexExists(TestContext context) throws SQLException {
-        try (Connection conn = context.dataSource.getConnection()) {
-            String indexCheckSql = getIndexCheckSql(context.dialect);
-            try (PreparedStatement ps = conn.prepareStatement(indexCheckSql)) {
-                switch (context.dialect) {
-                    case ORACLE:
-                        ps.setString(1, "IDX_STANDALONE_INDEX");
-                        ps.setString(2, "TEST_TABLE");
-                        break;
-                    case POSTGRESQL:
-                        ps.setString(1, "idx_standalone_index");
-                        break;
-                    case MYSQL:
-                    case MARIADB:
-                        ps.setString(1, "test_table");
-                        ps.setString(2, "idx_standalone_index");
-                        break;
-                    case SQLSERVER:
-                    case SYBASE:
-                        ps.setString(1, "idx_standalone_index");
-                        break;
-                    case H2:
-                    case HSQLDB:
-                    case DERBY:
-                    case SQLITE:
-                        ps.setString(1, "idx_standalone_index");
-                        break;
-                    default:
-                        ps.setString(1, "idx_standalone_index");
-                        break;
-                }
-
-                try (ResultSet rs = ps.executeQuery()) {
-                    boolean indexExists = rs.next();
-                    assertTrue(indexExists, "Index idx_standalone_index should exist");
-                }
-            }
-        }
-    }
-
-    private String getIndexCheckSql(SqlDialect dialect) {
-        switch (dialect) {
-            case POSTGRESQL:
-                return "SELECT indexname FROM pg_indexes WHERE indexname = ?";
-            case MYSQL:
-            case MARIADB:
-                return "SELECT INDEX_NAME FROM INFORMATION_SCHEMA.STATISTICS WHERE TABLE_NAME = ? AND INDEX_NAME = ?";
-            case ORACLE:
-                return "SELECT INDEX_NAME FROM USER_INDEXES WHERE INDEX_NAME = ? AND TABLE_NAME = ?";
-            case SQLSERVER:
-            case SYBASE:
-                return "SELECT name FROM sys.indexes WHERE name = ?";
-            case H2:
-            case HSQLDB:
-            case DERBY:
-            case SQLITE:
-                return "SELECT INDEX_NAME FROM INFORMATION_SCHEMA.INDEXES WHERE INDEX_NAME = ?";
-            default:
-                return "SELECT INDEX_NAME FROM INFORMATION_SCHEMA.INDEXES WHERE INDEX_NAME = ?";
-        }
-    }
-
     private void verifyPartialDataState(TestContext context) throws SQLException {
         try (Connection conn = context.dataSource.getConnection();
              PreparedStatement ps = conn.prepareStatement("SELECT name FROM test_table WHERE id = ?")) {
@@ -619,16 +476,4 @@ private void verifyPartialDataState(TestContext context) throws SQLException {
             }
         }
     }
-
-    private static class TestContext {
-        final DataSource dataSource;
-        final JdbcDatabaseContainer<?> container;
-        final SqlDialect dialect;
-
-        TestContext(DataSource dataSource, JdbcDatabaseContainer<?> container, SqlDialect dialect) {
-            this.dataSource = dataSource;
-            this.container = container;
-            this.dialect = dialect;
-        }
-    }
 }