refactor!: derive SqlAuditStore directly from SqlTargetSystem (#749)

Author: bercianor

cli/flamingock-cli/src/main/java/io/flamingock/cli/service/AuditService.java

@@ -42,6 +42,7 @@
 import io.flamingock.internal.core.store.AuditStore;
 import io.flamingock.targetsystem.dynamodb.DynamoDBTargetSystem;
 import io.flamingock.targetsystem.couchbase.CouchbaseTargetSystem;
+import io.flamingock.targetsystem.sql.SqlTargetSystem;
 import io.flamingock.targetystem.mongodb.sync.MongoDBSyncTargetSystem;
 import software.amazon.awssdk.services.dynamodb.DynamoDbClient;
 
@@ -191,7 +192,7 @@ private AuditStore<?> createSqlAuditStore(Context context) {
         // Create Couchbase cluster
         DataSource dataSource = SqlDataSourceFactory.createSqlDataSource(sqlConfig);
 
-        return new SqlAuditStore(dataSource)
+        return SqlAuditStore.from(new SqlTargetSystem("sql", dataSource))
             .withAuditRepositoryName(sqlConfig.getTable());
     }
 }

community/flamingock-auditstore-sql/src/main/java/io/flamingock/community/sql/driver/SqlAuditStore.java

@@ -24,6 +24,7 @@
 import io.flamingock.internal.util.id.RunnerId;
 import io.flamingock.community.sql.internal.SqlAuditPersistence;
 import io.flamingock.community.sql.internal.SqlLockService;
+import io.flamingock.targetsystem.sql.SqlTargetSystem;
 
 import javax.sql.DataSource;
 
@@ -38,10 +39,24 @@ public class SqlAuditStore implements CommunityAuditStore {
     private String lockRepositoryName = CommunityPersistenceConstants.DEFAULT_LOCK_STORE_NAME;
     private boolean autoCreate = true;
 
-    public SqlAuditStore(DataSource dataSource) {
+    private SqlAuditStore(DataSource dataSource) {
         this.dataSource = dataSource;
     }
 
+    /**
+     * Creates a {@link SqlAuditStore} using the same SQL datasource
+     * configured in the given {@link SqlTargetSystem}.
+     * <p>
+     * Only the underlying SQL datasource is reused.
+     * No additional target-system configuration is carried over.
+     *
+     * @param targetSystem the target system from which to derive the datasource
+     * @return a new audit store bound to the same SQL datasource as the target system
+     */
+    public static SqlAuditStore from(SqlTargetSystem targetSystem) {
+        return new SqlAuditStore(targetSystem.getDataSource());
+    }
+
     public SqlAuditStore withAuditRepositoryName(String auditRepositoryName) {
         this.auditRepositoryName = auditRepositoryName;
         return this;

community/flamingock-auditstore-sql/src/test/java/io/flamingock/community/sql/SqlAuditStoreTest.java

@@ -289,8 +289,8 @@ void happyPathWithMockedPipeline(SqlDialect sqlDialect, String dialectName) thro
                     new Trio<>(changeClasses[2], Collections.singletonList(Connection.class), null)
             ));
 
-            SqlAuditStore auditStore = new SqlAuditStore(context.dataSource);
             SqlTargetSystem targetSystem = new SqlTargetSystem("sql", context.dataSource);
+            SqlAuditStore auditStore = SqlAuditStore.from(targetSystem);
 
             FlamingockFactory.getCommunityBuilder()
                     .setAuditStore(auditStore)
@@ -363,8 +363,8 @@ void failedWithRollback(SqlDialect sqlDialect, String dialectName) throws Except
                     new Trio<>(changeClasses[2], Collections.singletonList(Connection.class), Collections.singletonList(Connection.class))
             ));
 
-            SqlAuditStore auditStore = new SqlAuditStore(context.dataSource);
             SqlTargetSystem targetSystem = new SqlTargetSystem("sql", context.dataSource);
+            SqlAuditStore auditStore = SqlAuditStore.from(targetSystem);
 
             assertThrows(PipelineExecutionException.class, () -> {
                 FlamingockFactory.getCommunityBuilder()
@@ -450,8 +450,8 @@ void failedWithoutRollback(SqlDialect sqlDialect, String dialectName) throws Exc
                     new Trio<>(changeClasses[2], Collections.singletonList(Connection.class), null)
             ));
 
-            SqlAuditStore auditStore = new SqlAuditStore(context.dataSource);
             SqlTargetSystem targetSystem = new SqlTargetSystem("sql", context.dataSource);
+            SqlAuditStore auditStore = SqlAuditStore.from(targetSystem);
 
             assertThrows(PipelineExecutionException.class, () -> {
                 FlamingockFactory.getCommunityBuilder()

core/target-systems/sql-target-system/src/main/java/io/flamingock/targetsystem/sql/SqlTargetSystem.java

@@ -37,6 +37,10 @@ public SqlTargetSystem(String id, DataSource dataSource) {
         this.dataSource = dataSource;
     }
 
+    public DataSource getDataSource() {
+        return dataSource;
+    }
+
     @Override
     public void initialize(ContextResolver baseContext) {
         this.validate();