fix: pr comments

Author: bercianor

cli/flamingock-cli/src/main/java/io/flamingock/cli/config/DatabaseConfig.java

@@ -271,7 +271,7 @@ public void setPassword(String password) {
         }
 
         public Optional<SqlDialect> getSqlDialect() {
-            return sqlDialect == null ? Optional.empty() :  Optional.of(sqlDialect);
+            return Optional.ofNullable(sqlDialect);
         }
 
         public void setSqlDialect(String sqlDialect) {
@@ -286,14 +286,7 @@ public SqlDialect getEffectiveSqlDialect() {
             if (parts.length < 2 || parts[1].isEmpty()) {
                 throw new IllegalStateException("Cannot determine SQL dialect from endpoint: " + this.endpoint);
             }
-            String dialect = parts[1].toLowerCase();
-            if ("firebirdsql".equals(dialect)) dialect = "firebird";
-            if ("informix-sqli".equals(dialect)) dialect = "informix";
-            try {
-                return SqlDialect.valueOf(dialect.toUpperCase());
-            } catch (IllegalArgumentException e) {
-                throw new IllegalArgumentException("Unsupported SQL Dialect: " + dialect, e);
-            }
+            return SqlDialect.fromString(parts[1].toLowerCase());
         }
 
         public String getDriverClassName() {

cli/flamingock-cli/src/main/java/io/flamingock/cli/factory/SqlDataSourceFactory.java

@@ -38,7 +38,7 @@ public static DataSource createSqlDataSource(DatabaseConfig.SqlConfig config) {
             throw new IllegalArgumentException("Database endpoint is required");
         }
 
-        if (!SqlDialect.SQLITE.equals(config.getEffectiveSqlDialect())) {
+        if (config.getEffectiveSqlDialect() != SqlDialect.SQLITE) {
             if (config.getUsername() == null) {
                 throw new IllegalArgumentException("Database username is required");
             }
@@ -50,7 +50,7 @@ public static DataSource createSqlDataSource(DatabaseConfig.SqlConfig config) {
         try {
             DataSource sqlDatasource;
 
-            if (config.getEffectiveSqlDialect().equals(SqlDialect.SQLITE)) {
+            if (config.getEffectiveSqlDialect() == (SqlDialect.SQLITE)) {
                 SQLiteDataSource sqliteDatasource = new SQLiteDataSource();
                 sqliteDatasource.setUrl(config.getEndpoint());
 

utils/sql-util/src/main/java/io/flamingock/internal/common/sql/SqlDialect.java

@@ -15,6 +15,9 @@
  */
 package io.flamingock.internal.common.sql;
 
+import java.util.Locale;
+import java.util.Optional;
+
 public enum SqlDialect {
     MYSQL,
     MARIADB,
@@ -28,5 +31,15 @@ public enum SqlDialect {
     FIREBIRD,
     INFORMIX,
     ORACLE,
-    DB2,
+    DB2;
+
+    public static SqlDialect fromString(String dialect) {
+        if ("firebirdsql".equals(dialect.toLowerCase())) return FIREBIRD;
+        if ("informix-sqli".equals(dialect.toLowerCase())) return INFORMIX;
+        try {
+            return SqlDialect.valueOf(dialect.toUpperCase());
+        } catch (IllegalArgumentException e) {
+            throw new IllegalArgumentException("Unsupported SQL Dialect: " + dialect, e);
+        }
+    }
 }