feat: disable hsqldb dialect

Author: davidfrigolet

community/flamingock-auditstore-sql/build.gradle.kts

@@ -21,7 +21,6 @@ dependencies {
     testImplementation("org.xerial:sqlite-jdbc:3.41.2.1")
     testImplementation("com.ibm.informix:jdbc:4.50.10")
     testImplementation("org.firebirdsql.jdbc:jaybird:4.0.10.java8")
-    testImplementation("org.hsqldb:hsqldb:2.7.2")
 }
 
 description = "SQL audit store implementation for distributed change auditing"

community/flamingock-auditstore-sql/src/main/java/io/flamingock/community/sql/internal/SqlAuditorDialectHelper.java

@@ -35,7 +35,6 @@ public String getCreateTableSqlString(String tableName) {
             case MYSQL:
             case MARIADB:
             case H2:
-            case HSQLDB:
                 return String.format(
                         "CREATE TABLE IF NOT EXISTS %s (" +
                                 "id %s PRIMARY KEY, " +
@@ -293,7 +292,6 @@ private String getAutoIncrementType() {
                 return "BIGSERIAL";
             case SQLITE:
             case H2:
-            case HSQLDB:
             case DB2:
             case FIREBIRD:
                 return "BIGINT GENERATED BY DEFAULT AS IDENTITY";
@@ -318,7 +316,6 @@ private String getClobType() {
                 return "LONGTEXT";
             case SQLITE:
             case H2:
-            case HSQLDB:
             case FIREBIRD:
             case INFORMIX:
             case ORACLE:
@@ -349,7 +346,6 @@ private String getBooleanType() {
                 return "TINYINT(1)";
             case POSTGRESQL:
             case H2:
-            case HSQLDB:
             case FIREBIRD:
             case INFORMIX:
                 return "BOOLEAN";

community/flamingock-auditstore-sql/src/main/java/io/flamingock/community/sql/internal/SqlLockDialectHelper.java

@@ -57,7 +57,6 @@ public String getCreateTableSqlString(String tableName) {
             case MARIADB:
             case SQLITE:
             case H2:
-            case HSQLDB:
                 return String.format(
                         "CREATE TABLE IF NOT EXISTS %s (" +
                                 "`key` VARCHAR(255) PRIMARY KEY," +
@@ -190,7 +189,6 @@ public String getInsertOrUpdateLockSqlString(String tableName) {
                                 "WHEN NOT MATCHED THEN INSERT (\"key\", status, owner, expires_at) VALUES (s.\"key\", s.status, s.owner, s.expires_at)",
                         tableName);
             case H2:
-            case HSQLDB:
                 return String.format(
                         "MERGE INTO %s (`key`, status, owner, expires_at) KEY (`key`) VALUES (?, ?, ?, ?)",
                         tableName);

community/flamingock-auditstore-sql/src/test/java/io/flamingock/community/sql/SqlAuditTestHelper.java

@@ -75,7 +75,6 @@ private static String getCreateTestTableSql(SqlDialect dialect) {
             case MARIADB:
             case SQLITE:
             case H2:
-            case HSQLDB:
             case FIREBIRD:
                 return "CREATE TABLE test_table (" +
                         "id VARCHAR(255) PRIMARY KEY, " +
@@ -114,7 +113,6 @@ private static String getCreateLockTableSql(SqlDialect dialect) {
             case MARIADB:
             case SQLITE:
             case H2:
-            case HSQLDB:
                 return "CREATE TABLE flamingockLock (" +
                         "`key` VARCHAR(255) PRIMARY KEY, " +
                         "status VARCHAR(32), " +
@@ -203,7 +201,6 @@ private static String getIndexCheckSql(SqlDialect dialect) {
             case FIREBIRD:
                 return "SELECT RDB$INDEX_NAME FROM RDB$INDICES WHERE RDB$INDEX_NAME = ?";
             case H2:
-            case HSQLDB:
             default:
                 return "SELECT INDEX_NAME FROM INFORMATION_SCHEMA.INDEXES WHERE INDEX_NAME = ?";
         }
@@ -233,7 +230,6 @@ public static void verifyIndexExists(TestContext context) throws SQLException {
                         ps.setString(1, "idx_standalone_index");
                         break;
                     case H2:
-                    case HSQLDB:
                         ps.setString(1, "IDX_STANDALONE_INDEX");
                         break;
                     case POSTGRESQL:

core/target-systems/sql-target-system/build.gradle.kts

@@ -16,7 +16,6 @@ dependencies {
     testImplementation("com.oracle.database.jdbc:ojdbc8:23.2.0.0")
     testImplementation("org.xerial:sqlite-jdbc:3.50.3.0")
     testImplementation("com.h2database:h2:2.2.220")
-    testImplementation("org.hsqldb:hsqldb:2.5.2")
     testImplementation("org.apache.derby:derbytools:10.15.2.0")
     testImplementation("org.firebirdsql.jdbc:jaybird:5.0.10.java8")
     testImplementation("org.testcontainers:junit-jupiter:1.18.3")

core/target-systems/sql-target-system/src/main/java/io/flamingock/targetsystem/sql/SqlAuditMarkerDialectHelper.java

@@ -77,11 +77,6 @@ public String getMarkSqlString(String tableName) {
                 return String.format(
                     "MERGE INTO %s (task_id, operation) KEY (task_id) VALUES (?, ?)",
                     tableName);
-            case HSQLDB:
-                return String.format(
-                    "MERGE INTO %s AS t USING (VALUES(?,?)) AS s(task_id,operation) ON t.task_id = s.task_id " +
-                        "WHEN MATCHED THEN UPDATE SET t.operation = s.operation WHEN NOT MATCHED THEN INSERT (task_id, operation) VALUES (s.task_id, s.operation)",
-                    tableName);
             case INFORMIX:
                 return String.format(
                     "INSERT INTO %s (task_id, operation) VALUES (?, ?) ON DUPLICATE KEY UPDATE operation = ?",
@@ -98,7 +93,6 @@ public String getCreateTableSqlString(String tableName) {
             case POSTGRESQL:
             case SQLITE:
             case H2:
-            case HSQLDB:
             case SQLSERVER:
             case SYBASE:
             case FIREBIRD:

core/target-systems/sql-target-system/src/test/java/io/flamingock/targetsystem/sql/SqlAuditMarkerDialectHelperTest.java

@@ -98,12 +98,6 @@ private void initForDialect(SqlDialect dialect, JdbcDatabaseContainer<?> contain
                     config.setPassword("");
                     config.setDriverClassName("org.sqlite.JDBC");
                     break;
-                case HSQLDB:
-                    config.setJdbcUrl("jdbc:hsqldb:mem:testdb");
-                    config.setUsername("testuser");
-                    config.setPassword("");
-                    config.setDriverClassName("org.hsqldb.jdbc.JDBCDriver");
-                    break;
                 case DB2:
                     config.setJdbcUrl("jdbc:h2:mem:testdb;MODE=DB2;DB_CLOSE_DELAY=-1");
                     config.setUsername("testuser");

utils/sql-util/src/main/java/io/flamingock/internal/common/sql/AbstractSqlDialectHelper.java

@@ -49,8 +49,9 @@ private SqlDialect fromDatabaseProductName(String productName) {
             return SqlDialect.SQLITE;
         } else if (v.contains("h2")) {
             return SqlDialect.H2;
-        } else if (v.contains("hsql")) {
+        /*} else if (v.contains("hsql")) {
             return SqlDialect.HSQLDB;
+         */
         } else if (v.contains("sql server")) {
             return SqlDialect.SQLSERVER;
         } else if (v.contains("sybase") || v.contains("adaptive server")) {

utils/sql-util/src/main/java/io/flamingock/internal/common/sql/SqlDialect.java

@@ -21,7 +21,8 @@ public enum SqlDialect {
     POSTGRESQL,
     SQLITE,
     H2,
-    HSQLDB,
+    //TODO implement
+    //HSQLDB,
     SQLSERVER,
     SYBASE,
     FIREBIRD,