[fir] Move save_result constraint to td file (#1108)

Author: clementval

flang/include/flang/Optimizer/Dialect/FIROps.td

@@ -362,7 +362,7 @@ def fir_SaveResultOp : fir_Op<"save_result", [AttrSizedOperandSegments]> {
 
   }];
 
-  let arguments = (ins AnyType:$value,
+  let arguments = (ins ArrayOrBoxOrRecord:$value,
                    Arg<AnyReferenceLike, "", [MemWrite]>:$memref,
                    Optional<AnyShapeType>:$shape,
                    Variadic<AnyIntegerType>:$typeparams);

flang/include/flang/Optimizer/Dialect/FIRTypes.td

@@ -588,4 +588,8 @@ def AnyCoordinateType : Type<AnyCoordinateLike.predicate, "coordinate type">;
 def AnyAddressableLike : TypeConstraint<Or<[fir_ReferenceType.predicate,
     FunctionType.predicate]>, "any addressable">;
 
+def ArrayOrBoxOrRecord : TypeConstraint<Or<[fir_SequenceType.predicate,
+    fir_BoxType.predicate, fir_RecordType.predicate]>,
+    "fir.box, fir.array or fir.type">;
+
 #endif // FIR_DIALECT_FIR_TYPES

flang/lib/Optimizer/Dialect/FIROps.cpp

@@ -2195,10 +2195,6 @@ static mlir::LogicalResult verify(fir::SaveResultOp op) {
   if (fir::isa_unknown_size_box(resultType))
     return op.emitOpError("cannot save !fir.box of unknown rank or type");
 
-  if (!resultType.isa<fir::BoxType, fir::SequenceType, fir::RecordType>())
-    return op.emitOpError(
-        "value operand must be a fir.box, fir.array or fir.type");
-
   if (resultType.isa<fir::BoxType>()) {
     if (op.shape() || !op.typeparams().empty())
       return op.emitOpError(

flang/test/Fir/invalid.fir

@@ -401,7 +401,7 @@ func @bad_save_result(%buffer : !fir.ref<!fir.box<!fir.array<*:f32>>>) {
 
 func @bad_save_result(%buffer : !fir.ref<f64>) {
   %res = fir.call @array_func() : () -> f64
-  // expected-error@+1 {{'fir.save_result' op value operand must be a fir.box, fir.array or fir.type}}
+  // expected-error@+1 {{'fir.save_result' op operand #0 must be fir.box, fir.array or fir.type, but got 'f64'}}
   fir.save_result %res to %buffer : f64, !fir.ref<f64>
   return
 }