Fix clang warning

clementval · web-flow · commit 404f1b2ab6f0 · 2021-09-24T22:17:33.000+02:00
diff --git a/flang/unittests/Optimizer/InternalNamesTest.cpp b/flang/unittests/Optimizer/InternalNamesTest.cpp
@@ -163,9 +163,9 @@ TEST(InternalNamesTest, doProgramEntry) {
 }
 
 TEST(InternalNamesTest, doNamelistGroup) {
-  llvm::StringRef actual = NameUniquer::doNamelistGroup({"mod1"}, {}, {"nlg"});
+  std::string actual = NameUniquer::doNamelistGroup({"mod1"}, {}, "nlg");
   std::string expectedMangledName = "_QMmod1Gnlg";
-  ASSERT_EQ(actual.str(), expectedMangledName);
+  ASSERT_EQ(actual, expectedMangledName);
 }
 
 TEST(InternalNamesTest, deconstructTest) {

Original file line number	Diff line number	Diff line change
`@@ -163,9 +163,9 @@ TEST(InternalNamesTest, doProgramEntry) {`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`TEST(InternalNamesTest, doNamelistGroup) {`
`166`		`- llvm::StringRef actual = NameUniquer::doNamelistGroup({"mod1"}, {}, {"nlg"});`
	`166`	`+ std::string actual = NameUniquer::doNamelistGroup({"mod1"}, {}, "nlg");`
`167`	`167`	`std::string expectedMangledName = "_QMmod1Gnlg";`
`168`		`- ASSERT_EQ(actual.str(), expectedMangledName);`
	`168`	`+ ASSERT_EQ(actual, expectedMangledName);`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`TEST(InternalNamesTest, deconstructTest) {`