Skip to content

Commit 6b03818

Browse files
committed
Respond to review comments.
1 parent 704d5e2 commit 6b03818

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

flang/lib/Lower/ConvertExpr.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2418,8 +2418,8 @@ class ArrayExprLowering {
24182418
using ExtValue = fir::ExtendedValue;
24192419
/// Active iteration space.
24202420
using IterSpace = const IterationSpace &;
2421-
/// Current continuation. Function that we generate IR for a single iteration
2422-
/// of the pending iterative loop structure.
2421+
/// Current continuation. Function that will generate IR for a single
2422+
/// iteration of the pending iterative loop structure.
24232423
using CC = std::function<ExtValue(IterSpace)>;
24242424
/// Projection continuation. Function that will project one iteration space
24252425
/// into another.
@@ -3375,8 +3375,8 @@ class ArrayExprLowering {
33753375
// Add the fir.result for all loops except the innermost one. We must also
33763376
// terminate the innermost explicit bounds loop here as well.
33773377
if (loopFirst > 0) {
3378-
builder.setInsertionPointToEnd(startBlock);
3379-
builder.create<fir::ResultOp>(loc, loops[loopFirst].getResult(0));
3378+
builder.setInsertionPointToEnd(startBlock);
3379+
builder.create<fir::ResultOp>(loc, loops[loopFirst].getResult(0));
33803380
}
33813381
for (std::remove_const_t<decltype(loopFirst)> i = loopFirst;
33823382
i + 1 < loopFirst + loopDepth; ++i) {
@@ -4488,8 +4488,7 @@ class ArrayExprLowering {
44884488
if (auto optShape = Fortran::evaluate::GetShape(x)) {
44894489
llvm::SmallVector<mlir::Value> result;
44904490
convertFEShape(*optShape, result);
4491-
if (!result.empty())
4492-
return result;
4491+
return result;
44934492
}
44944493
return {};
44954494
}

0 commit comments

Comments
 (0)