Minor touchups per review comments.

Author: schweitzpgi

flang/lib/Lower/ConvertExpr.cpp

@@ -5383,7 +5383,7 @@ class ArrayExprLowering {
                         : defaultStoreToDestination(substring);
       return [=](IterSpace iters) -> ExtValue { return lambda(iters); };
     }
-    if (semant == ConstituentSemantics::CustomCopyInCopyOut) {
+    if (isCustomCopyInCopyOut()) {
       // Create an array_modify to get the LHS element address and indicate
       // the assignment, the actual assignment must be implemented in
       // ccStoreToDest.

flang/lib/Optimizer/CodeGen/CodeGen.cpp

@@ -1215,10 +1215,8 @@ struct EmboxCommonConversion : public FIROpConversion<OP> {
 
     llvm::SmallVector<mlir::Value> typeparams = lenParams;
     if constexpr (!std::is_same_v<BOX, fir::EmboxOp>) {
-      if (!box.substr().empty() && fir::hasDynamicSize(boxTy.getEleTy())) {
-        // TODO: is this correct?
+      if (!box.substr().empty() && fir::hasDynamicSize(boxTy.getEleTy()))
         typeparams.push_back(box.substr()[1]);
-      }
     }
 
     // Write each of the fields with the appropriate values