Skip to content

Commit 2be8555

Browse files
kaadambryanpkc
authored andcommitted
Add Windows support to lit.cfg
* Enable running Flang tests on Windows
1 parent 1c99a08 commit 2be8555

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

test/lit.cfg

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ import lit.llvm
2727
lit.llvm.initialize(lit_config, config)
2828
lit.llvm.llvm_config.with_system_environment("COMPILER_PATH")
2929

30-
if platform.system() == 'Windows':
31-
lit_config.note('We do not support Windows, but hey, congratulations on porting to Windows!')
32-
raise SystemExit
33-
3430
# Configuration file for the 'lit' test runner.
3531

3632
# name: The name of this test suite.
@@ -45,6 +41,8 @@ if use_lit_shell:
4541
else:
4642
# Otherwise we default to internal on Windows and external elsewhere, as
4743
# bash on Windows is usually very slow.
44+
# NOTE: Flang tests have been tested only on Windows with MS Visual Studio environment,
45+
# the behaviour under Cygwin or MinGW is unknown.
4846
execute_external = (not sys.platform in ['win32'])
4947

5048
# testFormat: The test format to use to interpret tests.
@@ -219,7 +217,7 @@ def getClangBuiltinIncludeDir(clang):
219217
dir = cmd.stdout.read().strip()
220218
if sys.platform in ['win32'] and execute_external:
221219
# Don't pass dosish path separator to msys bash.exe.
222-
dir = dir.replace('\\', '/')
220+
dir = dir.replace(b'\\', b'/')
223221
# Ensure the result is an ascii string, across Python2.5+ - Python3.
224222
return str(dir.decode('ascii'))
225223

0 commit comments

Comments
 (0)