Improve the expansion of MINLOC/MAXLOC

Handle maxloc/maxval/minloc/minval expansion
if the expression being tested is not a simple
variable by using a temp.

Author: gklimowicz

tools/flang1/flang1exe/func.c

@@ -6235,6 +6235,19 @@ inline_reduction_f90(int ast, int dest, int lc, LOGICAL *doremove)
       astsubscrtmp = dest;
     } else
       astsubscrtmp = asttmp;
+    if (A_OPTYPEG(ast) == I_MAXLOC || A_OPTYPEG(ast) == I_MINLOC ||
+        A_OPTYPEG(ast) == I_MAXVAL || A_OPTYPEG(ast) == I_MINVAL) {
+      /* if the expression being reduced is nontrivial, assign to a temp */
+      if (A_TYPEG(ast2) == A_SUBSCR || A_TYPEG(ast2) == A_ID) {
+      } else {
+        /* create a temporary scalar */
+        int temprhs = sym_get_scalar(SYMNAME(sptr), "l", dtyperes);
+        /* assign the RHS to temprhs */
+        int std = mk_assn_stmt(mk_id(temprhs), ast2, dtyperes);
+        add_stmt_before(std, stdnext);
+        ast2 = mk_id(temprhs);
+      }
+    }
   }
   dtsclr = DDTG(dtypetmp);
   switch (A_OPTYPEG(ast)) {