Add missing check and return success/failure. For now, do not use the return value

Author: flanglet

src/transform/DivSufSort.cpp

@@ -1602,7 +1602,7 @@ uint64 DivSufSort::trPartition(int isad, int first, int middle, int last, int v)
     return ((uint64(first) << 32) | (uint64(last) & uint64(0xFFFFFFFF)));
 }
 
-void DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& budget)
+bool DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& budget)
 {
     const int incr = isad - isa;
     int limit = trIlg(last - first);
@@ -1648,7 +1648,7 @@ void DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& b
                         const StackElement* se = _trStack->pop();
 
                         if (se == nullptr)
-                            return;
+                            return false;
 
                         isad = se->_a;
                         first = se->_b;
@@ -1671,7 +1671,7 @@ void DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& b
                         const StackElement* se = _trStack->pop();
 
                         if (se == nullptr)
-                            return;
+                            return false;
 
                         isad = se->_a;
                         first = se->_b;
@@ -1685,6 +1685,9 @@ void DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& b
                 // tandem repeat copy
                 const StackElement* se = _trStack->pop();
 
+                if (se == nullptr)
+                    return false;
+
                 if (se->_d == 0) {
                     trCopy(isa, first, se->_b, se->_c, last, isad - isa);
                 }
@@ -1698,7 +1701,7 @@ void DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& b
                 se = _trStack->pop();
 
                 if (se == nullptr)
-                    return;
+                    return false;
 
                 isad = se->_a;
                 first = se->_b;
@@ -1770,7 +1773,7 @@ void DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& b
                             const StackElement* se = _trStack->pop();
 
                             if (se == nullptr)
-                                return;
+                                return false;
 
                             isad = se->_a;
                             first = se->_b;
@@ -1784,7 +1787,7 @@ void DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& b
                     const StackElement* se = _trStack->pop();
 
                     if (se == nullptr)
-                        return;
+                        return false;
 
                     isad = se->_a;
                     first = se->_b;
@@ -1947,7 +1950,7 @@ void DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& b
                         const StackElement* se = _trStack->pop();
 
                         if (se == nullptr)
-                            return;
+                            return false;
 
                         isad = se->_a;
                         first = se->_b;
@@ -1968,7 +1971,7 @@ void DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& b
                         const StackElement* se = _trStack->pop();
 
                         if (se == nullptr)
-                            return;
+                            return false;
 
                         isad = se->_a;
                         first = se->_b;
@@ -1991,7 +1994,7 @@ void DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& b
                 const StackElement* se = _trStack->pop();
 
                 if (se == nullptr)
-                    return;
+                    return false;
 
                 isad = se->_a;
                 first = se->_b;
@@ -2001,6 +2004,8 @@ void DivSufSort::trIntroSort(int isa, int isad, int first, int last, TRBudget& b
             }
         }
     }
+
+    return true;
 }
 
 int DivSufSort::trPivot(const int arr[], int isad, int first, int last) const

src/transform/DivSufSort.hpp

@@ -191,7 +191,7 @@ namespace kanzi
 
        uint64 trPartition(int isad, int first, int middle, int last, int v);
 
-       void trIntroSort(int isa, int isad, int first, int last, TRBudget& budget);
+       bool trIntroSort(int isa, int isad, int first, int last, TRBudget& budget);
 
        int trPivot(const int arr[], int isad, int first, int last) const;