Skip to content

Commit ed3f349

Browse files
committed
fix: delete config_items before scraper in test cleanup
The AfterAll blocks failed with FK constraint violations because config_items referencing the scraper were not deleted before the scraper itself.
1 parent 4aacfdf commit ed3f349

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

scrapers/external_entities_test.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ var _ = Describe("External users e2e test", Ordered, func() {
4444
err = DefaultContext.DB().Where("scraper_id = ?", scraperModel.ID).Delete(&dutymodels.ExternalRole{}).Error
4545
Expect(err).NotTo(HaveOccurred(), "failed to delete external roles")
4646

47+
err = DefaultContext.DB().Where("scraper_id = ?", scraperModel.ID).Delete(&models.ConfigItem{}).Error
48+
Expect(err).NotTo(HaveOccurred(), "failed to delete config items")
49+
4750
err = DefaultContext.DB().Delete(&scraperModel).Error
4851
Expect(err).NotTo(HaveOccurred(), "failed to delete scrape config")
4952
})
@@ -256,6 +259,9 @@ var _ = Describe("External roles with aliases e2e test", Ordered, func() {
256259
err = DefaultContext.DB().Where("scraper_id = ?", scraperModel.ID).Delete(&dutymodels.ExternalGroup{}).Error
257260
Expect(err).NotTo(HaveOccurred(), "failed to delete external groups")
258261

262+
err = DefaultContext.DB().Where("scraper_id = ?", scraperModel.ID).Delete(&models.ConfigItem{}).Error
263+
Expect(err).NotTo(HaveOccurred(), "failed to delete config items")
264+
259265
err = DefaultContext.DB().Delete(&scraperModel).Error
260266
Expect(err).NotTo(HaveOccurred(), "failed to delete scrape config")
261267
})
@@ -361,6 +367,9 @@ var _ = Describe("External groups with aliases e2e test", Ordered, func() {
361367
err = DefaultContext.DB().Where("scraper_id = ?", scraperModel.ID).Delete(&dutymodels.ExternalUser{}).Error
362368
Expect(err).NotTo(HaveOccurred(), "failed to delete external users")
363369

370+
err = DefaultContext.DB().Where("scraper_id = ?", scraperModel.ID).Delete(&models.ConfigItem{}).Error
371+
Expect(err).NotTo(HaveOccurred(), "failed to delete config items")
372+
364373
err = DefaultContext.DB().Delete(&scraperModel).Error
365374
Expect(err).NotTo(HaveOccurred(), "failed to delete scrape config")
366375
})

0 commit comments

Comments
 (0)