[feature] inject module registry to values

Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>

Author: ipaqsa

pkg/module_manager/models/modules/values_storage.go

@@ -183,6 +183,8 @@ func (vs *ValuesStorage) InjectRegistryValue(registry *Registry) {
 	vs.lock.Lock()
 	defer vs.lock.Unlock()
 
+	vs.schemaStorage.InjectRegistrySpec()
+
 	vs.resultValues["registry"] = registry
 }
 

pkg/values/validation/schemas.go

@@ -119,8 +119,6 @@ func validateObject(dataObj interface{}, s *spec.Schema, rootName string) error
 		return fmt.Errorf("validate config: schema is not provided")
 	}
 
-	injectRegistryProperty(s)
-
 	validator := validate.NewSchemaValidator(s, nil, rootName, strfmt.Default) // , validate.DisableObjectArrayTypeCheck(true)
 
 	switch v := dataObj.(type) {
@@ -162,18 +160,19 @@ func validateObject(dataObj interface{}, s *spec.Schema, rootName string) error
 	return allErrs.ErrorOrNil()
 }
 
-// injectRegistryProperty mutates the module schema to add a strict-typed "registry" field
-func injectRegistryProperty(s *spec.Schema) {
-	if len(s.Properties) == 0 {
+// InjectRegistrySpec mutates the module schema to add a strict-typed "registry" field
+func (st *SchemaStorage) InjectRegistrySpec() {
+	scheme := st.Schemas[ValuesSchema]
+	if scheme == nil || len(scheme.Properties) == 0 {
 		return
 	}
 
 	// skip if already present
-	if _, exists := s.Properties["registry"]; exists {
+	if _, exists := scheme.Properties["registry"]; exists {
 		return
 	}
 
-	s.Properties["registry"] = spec.Schema{
+	scheme.Properties["registry"] = spec.Schema{
 		SchemaProps: spec.SchemaProps{
 			Type:                 spec.StringOrArray{"object"},
 			AdditionalProperties: &spec.SchemaOrBool{Allows: false},
@@ -301,8 +300,6 @@ func PrepareSchemas(configBytes, valuesBytes []byte) (map[SchemaType]*spec.Schem
 			&schema.CopyTransformer{},
 			// Transform x-required-for-helm
 			&schema.RequiredForHelmTransformer{},
-			// Allow unknown fields (e.g., "registry") to pass validation
-			&schema.AdditionalPropertiesTransformer{},
 		)
 	}