Skip to content

Commit 85f50b0

Browse files
committed
Resolve some of RuboCop offenses from new enabled cops
1 parent 4ae1c6e commit 85f50b0

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

grape-swagger-representable.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
require_relative './lib/grape-swagger/representable/version'
3+
require_relative 'lib/grape-swagger/representable/version'
44

55
Gem::Specification.new do |s|
66
s.name = 'grape-swagger-representable'

lib/grape-swagger/representable.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ module Representable
1111
end
1212
end
1313

14-
GrapeSwagger.model_parsers.register(::GrapeSwagger::Representable::Parser, ::Representable::Decorator)
14+
GrapeSwagger.model_parsers.register(GrapeSwagger::Representable::Parser, Representable::Decorator)

spec/grape-swagger/representers/response_inline_representer_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class ResponseModelApi < Grape::API
4848
is_array: true,
4949
http_codes: [{ code: 200, message: 'OK', model: Representers::Something }]
5050
get '/something' do
51-
something = OpenStruct.new text: 'something'
51+
something = Struct.new('Something', :text).new('something')
5252
Representers::Something.new(something).to_hash
5353
end
5454

@@ -64,10 +64,10 @@ class ResponseModelApi < Grape::API
6464
end
6565
get '/something/:id' do
6666
if params[:id] == 1
67-
something = OpenStruct.new text: 'something'
67+
something = Struct.new('Something', :text).new('something')
6868
Representers::Something.new(something).to_hash
6969
else
70-
error = OpenStruct.new code: 'some_error', message: 'Some error'
70+
error = Struct.new('SomeError', :code, :message).new('some_error', 'Some error')
7171
Representers::Error.new(error).to_hash
7272
end
7373
end

spec/grape-swagger/representers/response_representer_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class ResponseModelApi < Grape::API
5353
is_array: true,
5454
http_codes: [{ code: 200, message: 'OK', model: Representers::Something }]
5555
get '/something' do
56-
something = OpenStruct.new text: 'something'
56+
something = Struct.new('Something', :text).new('something')
5757
Representers::Something.new(something).to_hash
5858
end
5959

@@ -69,10 +69,10 @@ class ResponseModelApi < Grape::API
6969
end
7070
get '/something/:id' do
7171
if params[:id] == 1
72-
something = OpenStruct.new text: 'something'
72+
something = Struct.new('Something', :text).new('something')
7373
Representers::Something.new(something).to_hash
7474
else
75-
error = OpenStruct.new code: 'some_error', message: 'Some error'
75+
error = Struct.new('SomeError', :code, :message).new('some_error', 'Some error')
7676
Representers::Error.new(error).to_hash
7777
end
7878
end
@@ -222,7 +222,7 @@ class ResponseEntityApi < Grape::API
222222
is_array: true,
223223
entity: Representers::SomeEntity
224224
get '/some_entity' do
225-
something = OpenStruct.new text: 'something'
225+
something = Struct.new('Something', :text).new('something')
226226
Representers::SomeEntity.new(something).to_hash
227227
end
228228

0 commit comments

Comments
 (0)