lint

Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>

Author: ldmonster

.golangci.yaml

@@ -11,21 +11,25 @@ linters:
     - depguard
     - dogsled
     - durationcheck
+    - errcheck
     - gochecknoinits
     - gocritic
     - goprintffuncname
     - govet
     - ineffassign
     - misspell
+    - musttag
     - nolintlint
     - nonamedreturns
     - prealloc
     - revive
     - sloglint
     - staticcheck
     - unconvert
+    - unparam
     - unused
     - whitespace
+    - usestdlibvars
   settings:
     depguard:
       rules:

pkg/debug/debug-cmd.go

@@ -55,15 +55,15 @@ func DefineDebugCommands(kpApp *kingpin.Application) {
 					return err
 				}
 
-				output.Write(out)
+				_, _ = output.Write(out)
 				if !watch {
 					break
 				}
 
 				time.Sleep(refreshInterval)
 				output.ClearScreen()
 				output.MoveCursor(1, 1)
-				output.WriteString(time.Now().Format(time.RFC3339))
+				_, _ = output.WriteString(time.Now().Format(time.RFC3339))
 				output.MoveCursor(3, 1)
 			}
 

pkg/hook/config/config_v1.go

@@ -212,10 +212,7 @@ func (cv1 *HookConfigV1) ConvertAndCheck(c *HookConfig) error {
 			return fmt.Errorf("invalid kubernetesValidating config [%d]: %w", i, err)
 		}
 
-		validating, err := convertValidating(rawValidating)
-		if err != nil {
-			return err
-		}
+		validating := convertValidating(rawValidating)
 
 		c.KubernetesValidating = append(c.KubernetesValidating, validating)
 	}
@@ -237,10 +234,7 @@ func (cv1 *HookConfigV1) ConvertAndCheck(c *HookConfig) error {
 			return fmt.Errorf("invalid kubernetesMutating config [%d]: %w", i, err)
 		}
 
-		mutating, err := convertMutating(rawMutating)
-		if err != nil {
-			return err
-		}
+		mutating := convertMutating(rawMutating)
 
 		c.KubernetesMutating = append(c.KubernetesMutating, mutating)
 	}
@@ -421,7 +415,7 @@ func (cv1 *HookConfigV1) CheckAdmission(kubeConfigs []htypes.OnKubernetesEventCo
 	return allErr
 }
 
-func convertValidating(cfgV1 KubernetesAdmissionConfigV1) (htypes.ValidatingConfig, error) {
+func convertValidating(cfgV1 KubernetesAdmissionConfigV1) htypes.ValidatingConfig {
 	cfg := htypes.ValidatingConfig{}
 
 	cfg.Group = cfgV1.Group
@@ -435,23 +429,28 @@ func convertValidating(cfgV1 KubernetesAdmissionConfigV1) (htypes.ValidatingConf
 		Name:  cfgV1.Name,
 		Rules: cfgV1.Rules,
 	}
+
 	if cfgV1.Namespace != nil {
 		webhook.NamespaceSelector = cfgV1.Namespace.LabelSelector
 	}
+
 	if cfgV1.LabelSelector != nil {
 		webhook.ObjectSelector = cfgV1.LabelSelector
 	}
+
 	if cfgV1.FailurePolicy != nil {
 		webhook.FailurePolicy = cfgV1.FailurePolicy
 	} else {
 		defaultFailurePolicy := v1.FailurePolicyType(app.ValidatingWebhookSettings.DefaultFailurePolicy)
 		webhook.FailurePolicy = &defaultFailurePolicy
 	}
+
 	if cfgV1.SideEffects != nil {
 		webhook.SideEffects = cfgV1.SideEffects
 	} else {
 		webhook.SideEffects = &DefaultSideEffects
 	}
+
 	if cfgV1.TimeoutSeconds != nil {
 		webhook.TimeoutSeconds = cfgV1.TimeoutSeconds
 	} else {
@@ -463,13 +462,14 @@ func convertValidating(cfgV1 KubernetesAdmissionConfigV1) (htypes.ValidatingConf
 	cfg.Webhook = &admission.ValidatingWebhookConfig{
 		ValidatingWebhook: webhook,
 	}
+
 	cfg.Webhook.Metadata.LogLabels = map[string]string{}
 	cfg.Webhook.Metadata.MetricLabels = map[string]string{}
 
-	return cfg, nil
+	return cfg
 }
 
-func convertMutating(cfgV1 KubernetesAdmissionConfigV1) (htypes.MutatingConfig, error) {
+func convertMutating(cfgV1 KubernetesAdmissionConfigV1) htypes.MutatingConfig {
 	cfg := htypes.MutatingConfig{}
 
 	cfg.Group = cfgV1.Group
@@ -484,22 +484,27 @@ func convertMutating(cfgV1 KubernetesAdmissionConfigV1) (htypes.MutatingConfig,
 		Name:  cfgV1.Name,
 		Rules: cfgV1.Rules,
 	}
+
 	if cfgV1.Namespace != nil {
 		webhook.NamespaceSelector = cfgV1.Namespace.LabelSelector
 	}
+
 	if cfgV1.LabelSelector != nil {
 		webhook.ObjectSelector = cfgV1.LabelSelector
 	}
+
 	if cfgV1.FailurePolicy != nil {
 		webhook.FailurePolicy = cfgV1.FailurePolicy
 	} else {
 		webhook.FailurePolicy = &DefaultFailurePolicy
 	}
+
 	if cfgV1.SideEffects != nil {
 		webhook.SideEffects = cfgV1.SideEffects
 	} else {
 		webhook.SideEffects = &DefaultSideEffects
 	}
+
 	if cfgV1.TimeoutSeconds != nil {
 		webhook.TimeoutSeconds = cfgV1.TimeoutSeconds
 	} else {
@@ -511,10 +516,11 @@ func convertMutating(cfgV1 KubernetesAdmissionConfigV1) (htypes.MutatingConfig,
 	cfg.Webhook = &admission.MutatingWebhookConfig{
 		MutatingWebhook: webhook,
 	}
+
 	cfg.Webhook.Metadata.LogLabels = map[string]string{}
 	cfg.Webhook.Metadata.MetricLabels = map[string]string{}
 
-	return cfg, nil
+	return cfg
 }
 
 func (cv1 *HookConfigV1) CheckConversion(kubeConfigs []htypes.OnKubernetesEventConfig, cfgV1 KubernetesConversionConfigV1) error {

pkg/kube_events_manager/namespace_informer.go

@@ -70,7 +70,7 @@ func (ni *namespaceInformer) createSharedInformer(addFn func(string), delFn func
 	ni.SharedInformer = corev1.NewFilteredNamespaceInformer(ni.KubeClient, resyncPeriod, indexers, tweakListOptions)
 	ni.addFn = addFn
 	ni.delFn = delFn
-	ni.SharedInformer.AddEventHandler(ni) // SharedNamespaceInformerEventHandler(ni, addFn, delFn))
+	_, _ = ni.SharedInformer.AddEventHandler(ni) // SharedNamespaceInformerEventHandler(ni, addFn, delFn))
 
 	listOptions := metav1.ListOptions{}
 	tweakListOptions(&listOptions)

pkg/kube_events_manager/types/types_test.go

@@ -9,6 +9,7 @@ import (
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 )
 
+//nolint:unparam
 func newObj(kind, ns, name, filterResult string) *ObjectAndFilterResult {
 	return &ObjectAndFilterResult{
 		FilterResult: filterResult,

pkg/shell-operator/combine_binding_context.go

@@ -23,6 +23,7 @@ type CombineResult struct {
 // If input task has no metadata, result will be nil.
 // Metadata should implement HookNameAccessor, BindingContextAccessor and MonitorIDAccessor interfaces.
 // DEV WARNING! Do not use HookMetadataAccessor here. Use only *Accessor interfaces because this method is used from addon-operator.
+// nolint: unparam
 func (op *ShellOperator) combineBindingContextForHook(tqs *queue.TaskQueueSet, q *queue.TaskQueue, t task.Task, stopCombineFn func(tsk task.Task) bool) *CombineResult {
 	if q == nil {
 		return nil

pkg/utils/file/file_test.go

@@ -49,9 +49,10 @@ func prepareTestDirTree() (string, error) {
 
 func createExecutableFile(file string) error {
 	if _, err := os.Create(file); err != nil {
-		return err
+		return fmt.Errorf("create: %w", err)
 	}
-	os.Chmod(file, 0o777)
+
+	_ = os.Chmod(file, 0o777)
 
 	return nil
 }

test/hook/context/generator_test.go

@@ -13,6 +13,7 @@ import (
 
 func parseContexts(contexts string) []bctx.BindingContext {
 	var parsedBindingContexts []bctx.BindingContext
+	//nolint: musttag
 	_ = json.Unmarshal([]byte(contexts), &parsedBindingContexts)
 	return parsedBindingContexts
 }