release: Remove package streaming feature.

Author: Aetopia

src/Flarial.Launcher/Management/AppSettings.cs

@@ -10,9 +10,6 @@ sealed class AppSettings
     [DataMember]
     internal bool AutomaticUpdates { get; set; } = true;
 
-    [DataMember]
-    internal bool DownloadVersions { get; set; } = false;
-
     [DataMember]
     internal bool WaitForInitialization { get; set; } = true;
 
@@ -27,7 +24,6 @@ void OnDeserializing(StreamingContext context)
     {
         UseCustomDll = false;
         AutomaticUpdates = true;
-        DownloadVersions = false;
         CustomDllPath = string.Empty;
         WaitForInitialization = true;
     }

src/Flarial.Launcher/Pages/SettingsPage.cs

@@ -19,15 +19,6 @@ sealed class SettingsPage : Grid
         OffContent = "No, ask before updating."
     };
 
-    readonly ToggleSwitch _downloadVersions = new()
-    {
-        Header = "Should the launcher download first then install a version?",
-        VerticalAlignment = VerticalAlignment.Stretch,
-        HorizontalAlignment = HorizontalAlignment.Stretch,
-        OnContent = "Yes, download first then install.",
-        OffContent = "No, download & install at once."
-    };
-
     readonly ToggleSwitch _waitForInitialization = new()
     {
         Header = "Should the launcher wait for the game to initialize?",
@@ -41,7 +32,6 @@ void OnToggleSwitchToggled(object sender, RoutedEventArgs args)
     {
         var value = ((ToggleSwitch)sender).IsOn;
         if (ReferenceEquals(_automaticUpdates, sender)) _settings.AutomaticUpdates = value;
-        else if (ReferenceEquals(_downloadVersions, sender)) _settings.DownloadVersions = value;
         else if (ReferenceEquals(_waitForInitialization, sender)) _settings.WaitForInitialization = value;
     }
 
@@ -69,7 +59,6 @@ internal SettingsPage(AppSettings settings)
         SetColumn(folderButtonsBox, 0);
 
         stackPanel.Children.Add(_automaticUpdates);
-        stackPanel.Children.Add(_downloadVersions);
         stackPanel.Children.Add(_waitForInitialization);
         stackPanel.Children.Add(new DllSelectionBox(settings));
 
@@ -78,10 +67,8 @@ internal SettingsPage(AppSettings settings)
 
         _automaticUpdates.Toggled += OnToggleSwitchToggled;
         _waitForInitialization.Toggled += OnToggleSwitchToggled;
-        _downloadVersions.Toggled += OnToggleSwitchToggled;
 
         _automaticUpdates.IsOn = _settings.AutomaticUpdates;
-        _downloadVersions.IsOn = _settings.DownloadVersions;
         _waitForInitialization.IsOn = _settings.WaitForInitialization;
     }
 }

src/Flarial.Launcher/Pages/VersionsPage.cs

@@ -80,7 +80,7 @@ async void OnButtonClick(object sender, RoutedEventArgs args)
             _item = (VersionItem)_listBox.SelectedItem;
             _listBox.ScrollIntoView(_item);
 
-            await _item.InstallAsync(_settings.DownloadVersions, OnVersionItemInstallAsync);
+            await _item.InstallAsync(OnVersionItemInstallAsync);
         }
         finally
         {

src/Flarial.Runtime/Versions/GDKVersionItem.cs

@@ -83,12 +83,12 @@ protected override async Task<string> GetUriAsync()
         throw new InvalidOperationException();
     }
 
-    public override async Task InstallAsync(bool download, Action<int, bool> callback)
+    public override async Task InstallAsync(Action<int, bool> callback)
     {
         if (!Minecraft.IsGamingServicesInstalled)
             throw new Win32Exception((int)ERROR_INSTALL_PREREQUISITE_FAILED);
 
-        await base.InstallAsync(download, callback);
+        await base.InstallAsync(callback);
         var path = Path.Combine(Minecraft.Package.InstalledPath, "gamelaunchhelper.dll");
 
         using var stream = File.Create(path);

src/Flarial.Runtime/Versions/VersionItem.cs

@@ -27,7 +27,7 @@ internal static string Stringify(string version)
         return key._minor >= 26 ? $"{key._minor}.{key._build}" : version;
     }
 
-    public virtual async Task InstallAsync(bool download, Action<int, bool> callback)
+    public virtual async Task InstallAsync(Action<int, bool> callback)
     {
         if (!Minecraft.IsInstalled)
             throw new Win32Exception((int)ERROR_INSTALL_PACKAGE_NOT_FOUND);
@@ -38,11 +38,8 @@ public virtual async Task InstallAsync(bool download, Action<int, bool> callback
         var path = Path.Combine(s_path, Path.GetRandomFileName());
         try
         {
-            var downloadUri = await GetUriAsync();
-            Uri appUri = new(download ? path : downloadUri);
-
-            if (download) await HttpStack.DownloadAsync(downloadUri, path, _ => callback(_, false));
-            await Task.Run(() => AppManager.Add(appUri, _ => callback(_, true)));
+            await HttpStack.DownloadAsync(await GetUriAsync(), path, _ => callback(_, false));
+            await Task.Run(() => AppManager.Add(new(path), _ => callback(_, true)));
         }
         finally
         {