fix: serve command not working, add test scaffolding

Author: imorland

extensions/realtime/composer.json

@@ -68,11 +68,19 @@
         "kyrne/websocket": "*"
     },
     "scripts": {
-        "analyse:phpstan": "phpstan analyse",
-        "clear-cache:phpstan": "phpstan clear-result-cache"
+        "test": [
+            "@test:unit",
+            "@test:integration"
+        ],
+        "test:unit": "phpunit -c tests/phpunit.unit.xml",
+        "test:integration": "phpunit -c tests/phpunit.integration.xml",
+        "test:setup": "@php tests/integration/setup.php"
     },
     "scripts-descriptions": {
-        "analyse:phpstan": "Run static analysis"
+        "test": "Runs all tests.",
+        "test:unit": "Runs all unit tests.",
+        "test:integration": "Runs all integration tests.",
+        "test:setup": "Sets up a database for use with integration tests. Execute this only once."
     },
     "require-dev": {
         "fof/best-answer": "^2.0.0-beta",

extensions/realtime/resources/routes/websocket.php

@@ -7,8 +7,8 @@
  * LICENSE file that was distributed with this source code.
  */
 
-use Blomstra\Realtime\Websocket\Connection;
-use Blomstra\Realtime\Websocket\Logger\WebsocketLogger;
+use Flarum\Realtime\Websocket\Connection;
+use Flarum\Realtime\Websocket\Logger\WebsocketLogger;
 use Ratchet\WebSocket\MessageComponentInterface;
 use Ratchet\WebSocket\WsServer;
 use Symfony\Component\Routing\Route;

extensions/realtime/src/Websocket/Console/ServeCommand.php

@@ -110,6 +110,16 @@ protected function loggers(): void
 
     public function errorHandler(int $errno, string $errstr, string $errfile, int $errline): bool
     {
+        // Don't throw exceptions for deprecation notices, warnings, or notices in debug mode
+        // Just log them to output instead
+        if (in_array($errno, [E_DEPRECATED, E_USER_DEPRECATED, E_NOTICE, E_USER_NOTICE])) {
+            if ($this->option('debug')) {
+                $this->warn("[$errno] $errstr in $errfile:$errline");
+            }
+            return true;
+        }
+
+        // Throw exceptions for actual errors
         throw new \Exception("$errno, $errstr, $errfile:$errline");
     }
 

extensions/realtime/tests/fixtures/.gitkeep

@@ -0,0 +1,12 @@
+<?php
+
+/*
+ * This file is part of Flarum.
+ *
+ * For detailed copyright and license information, please view the
+ * LICENSE file that was distributed with this source code.
+ */
+
+$setup = require __DIR__.'/../../../../php-packages/testing/bootstrap/monorepo.php';
+
+$setup->run();

extensions/realtime/tests/integration/setup.php

@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="../../../vendor/phpunit/phpunit/phpunit.xsd"
+    backupGlobals="false"
+    cacheDirectory=".phpunit.cache"
+    backupStaticProperties="false"
+    colors="true"
+    processIsolation="true"
+    stopOnFailure="false"
+    bootstrap="../../../php-packages/testing/bootstrap/monorepo.php"
+>
+    <source>
+        <include>
+            <directory suffix=".php">../src/</directory>
+        </include>
+    </source>
+    <testsuites>
+        <testsuite name="Flarum Integration Tests">
+            <directory suffix="Test.php">./integration</directory>
+             <exclude>./integration/tmp</exclude>
+        </testsuite>
+    </testsuites>
+</phpunit>

extensions/realtime/tests/phpunit.integration.xml

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="../../../vendor/phpunit/phpunit/phpunit.xsd"
+    backupGlobals="false"
+    cacheDirectory=".phpunit.cache"
+    backupStaticProperties="false"
+    colors="true"
+    processIsolation="false"
+    stopOnFailure="false"
+    bootstrap="../../../php-packages/testing/bootstrap/monorepo.php"
+>
+    <source>
+        <include>
+            <directory suffix=".php">../src/</directory>
+        </include>
+    </source>
+    <testsuites>
+        <testsuite name="Flarum Unit Tests">
+            <directory suffix="Test.php">./unit</directory>
+        </testsuite>
+    </testsuites>
+</phpunit>