Simplifies boolean mask negation logic

algo-home · algo-home · commit 2aba69741862 · 2025-09-12T22:31:02.000+08:00
Replaces `== False` comparison with the more idiomatic `~` operator for boolean negation, improving code readability and following Python best practices.
diff --git a/flash_dmattn/integrations/modeling_flash_dynamic_mask_attention_utils.py b/flash_dmattn/integrations/modeling_flash_dynamic_mask_attention_utils.py
@@ -101,7 +101,7 @@ def _flash_dynamic_mask_attention_forward(
             )
             attention_mask = torch.zeros_like(attention_bias, dtype=torch.bool, device=attention_bias.device)
             attention_mask = attention_mask.scatter(-1, topk_indices, topk_values != min_dtype)
-            attention_bias = attention_bias.masked_fill(attention_mask == False, min_dtype)
+            attention_bias = attention_bias.masked_fill(~attention_mask, min_dtype)
 
     out = flash_fn(
         query_states, key_states, value_states, attn_mask=attention_mask, attn_bias=attention_bias, scale=softmax_scale, is_causal=is_causal

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ def _flash_dynamic_mask_attention_forward(`
`101`	`101`	`)`
`102`	`102`	`attention_mask = torch.zeros_like(attention_bias, dtype=torch.bool, device=attention_bias.device)`
`103`	`103`	`attention_mask = attention_mask.scatter(-1, topk_indices, topk_values != min_dtype)`
`104`		`- attention_bias = attention_bias.masked_fill(attention_mask == False, min_dtype)`
	`104`	`+ attention_bias = attention_bias.masked_fill(~attention_mask, min_dtype)`
`105`	`105`
`106`	`106`	`out = flash_fn(`
`107`	`107`	`query_states, key_states, value_states, attn_mask=attention_mask, attn_bias=attention_bias, scale=softmax_scale, is_causal=is_causal`